github-fixes-#31-error-maximum-call-stack-exceeded (#39)

* github-fixes-#31-error-maximum-call-stack-exceeded

* remove equals function since it does not work with cyclic objects and it is not used anymore

Author: DanaShalev

src/Util/Util.js

@@ -2,5 +2,4 @@ export debounce from './debounce';
 export firstDefined from './firstDefined';
 export closestAbove from './closestAbove';
 export {requestAnimationFrame, cancelAnimationFrame } from './requestAnimationFrame';
-export equals from './equals';
 export isElement from './isElement';

src/Util/equals.js

@@ -1,7 +1,7 @@
 import React, {Component} from 'react';
 import cloudinary, {Util} from 'cloudinary-core';
 import CloudinaryComponent from '../CloudinaryComponent';
-import {debounce, firstDefined, closestAbove, requestAnimationFrame, equals, isElement} from '../../Util';
+import {debounce, firstDefined, closestAbove, requestAnimationFrame, isElement} from '../../Util';
 
 /**
  * A component representing a Cloudinary served image
@@ -32,10 +32,6 @@ class Image extends CloudinaryComponent {
     return (this.element && this.element.ownerDocument) ? (this.element.ownerDocument.defaultView || windowRef) : windowRef;
   }
 
-  shouldComponentUpdate( nextProps, nextState){
-    return !( equals(this.props, nextProps) && equals(this.state, nextState));
-  }
-
   componentWillReceiveProps(nextProps, nextContext) {
     let state = this.prepareState(nextProps, nextContext);
     this.setState(state);

src/components/Image/Image.js

@@ -2,6 +2,7 @@ import React from 'react';
 import { expect } from 'chai';
 import { shallow, mount, render } from 'enzyme';
 import Image from '../src/components/Image';
+import Transformation from '../src/components/Transformation';
 
 describe('Image', () => {
   beforeEach(() => {
@@ -51,4 +52,17 @@ describe('Image', () => {
     expect(tag.props()).not.to.have.property('default_image');
 
   });
+  it("should not fail to update cyclic property on an image element with transformation", function() {
+      // makes sure Issue #31 - Error: Maximum call call stack size exceeded does not reoccur
+      let obj1 = {}, obj2 = {};
+      obj1.me = obj1;
+      obj2.me = obj2;
+
+      let tag = shallow(<Image publicId="sample" cloudName="demo"><Transformation effect='art:hokusai'/></Image>);
+      tag.setProps({cyclicProp: obj1});
+      tag.setProps({cyclicProp: obj2});
+
+      tag.setState({cyclicProp: obj1});
+      tag.setState({cyclicProp: obj2});
+  });
 });