feat: Make CREATE EXTENSION tests optional

Author: mbiagetti

dagger/maintenance/main.go

@@ -174,6 +174,17 @@ func (m *Maintenance) GenerateTestingValues(
 			targetExtensionImage)
 	}
 
+	var extensions []map[string]string
+	var expectedExtensions []map[string]any
+	if metadata.CreateExtension {
+		extensions = []map[string]string{
+			{"name": metadata.SQLName, "version": version},
+		}
+		expectedExtensions = []map[string]any{
+			{"applied": true, "name": metadata.SQLName},
+		}
+	}
+
 	// Build values.yaml content
 	values := map[string]any{
 		"name":                     metadata.Name,
@@ -186,6 +197,9 @@ func (m *Maintenance) GenerateTestingValues(
 		"extension_image":          targetExtensionImage,
 		"pg_image":                 pgImage,
 		"version":                  version,
+		"create_extension":         metadata.CreateExtension,
+		"extensions":               extensions,
+		"expected_extensions":      expectedExtensions,
 	}
 	valuesYaml, err := yaml.Marshal(values)
 	if err != nil {

dagger/maintenance/parse.go

@@ -28,6 +28,7 @@ type extensionMetadata struct {
 	DynamicLibraryPath     []string   `hcl:"dynamic_library_path" cty:"dynamic_library_path"`
 	LdLibraryPath          []string   `hcl:"ld_library_path" cty:"ld_library_path"`
 	AutoUpdateOsLibs       bool       `hcl:"auto_update_os_libs" cty:"auto_update_os_libs"`
+	CreateExtension        bool       `hcl:"create_extension" cty:"create_extension"`
 	Versions               versionMap `hcl:"versions" cty:"versions"`
 	Remain                 hcl.Body   `hcl:",remain"`
 }

pgaudit/metadata.hcl

@@ -7,6 +7,7 @@ metadata = {
   dynamic_library_path     = []
   ld_library_path          = []
   auto_update_os_libs      = false
+  create_extension         = true
 
   versions = {
     bookworm = {

pgvector/metadata.hcl

@@ -7,6 +7,7 @@ metadata = {
   dynamic_library_path     = []
   ld_library_path          = []
   auto_update_os_libs      = false
+  create_extension         = true
 
   versions = {
     bookworm = {

postgis/metadata.hcl

@@ -7,6 +7,7 @@ metadata = {
   dynamic_library_path     = []
   ld_library_path          = ["/system"]
   auto_update_os_libs      = true
+  create_extension         = true
 
   versions = {
     bookworm = {

templates/metadata.hcl.tmpl

@@ -9,6 +9,7 @@ metadata = {
   dynamic_library_path     = []
   ld_library_path          = []
   auto_update_os_libs      = false
+  create_extension         = true
 
   versions = {
     {{- range $distro := .Distros}}

test/check-extension.yaml

@@ -13,6 +13,8 @@ spec:
             value: ($values.sql_name)
           - name: EXT_VERSION
             value: ($values.version)
+          - name: CREATE_EXTENSION
+            value: (to_string($values.create_extension))
           - name: DB_URI
             valueFrom:
               secretKeyRef:
@@ -23,6 +25,10 @@ spec:
         args:
          - |
            set -e
+           if [ "$CREATE_EXTENSION" != "true" ]; then
+             echo "Skipping extension check (create_extension=false)"
+             exit 0
+           fi
            DB_URI=$(echo $DB_URI | sed "s|/\*|/|")
            test "$(psql "$DB_URI" -tAc "SELECT EXISTS (SELECT FROM pg_catalog.pg_extension WHERE extname = '${EXT_SQL_NAME}' AND extversion = '${EXT_VERSION}')" -q)" = "t"
            echo "Extension '${EXT_SQL_NAME} v${EXT_VERSION}' is installed!"

test/database-assert.yaml

@@ -4,7 +4,3 @@ metadata:
   name: (join('-', [$values.name, 'app']))
 status:
   applied: true
-  extensions:
-  - applied: true
-    name: ($values.sql_name)
-  observedGeneration: 1

test/database.yaml

@@ -7,6 +7,4 @@ spec:
   owner: app
   cluster:
     name: ($values.name)
-  extensions:
-  - name: ($values.sql_name)
-    version: ($values.version)
+  extensions: ($values.extensions)