Add acceptance testing

Author: joshsmith

.env.example

@@ -6,7 +6,12 @@ export CLOUDEX_SECRET=
 export CLOUDFRONT_DOMAIN=
 export GITHUB_APP_CLIENT_ID=
 export GITHUB_APP_CLIENT_SECRET=
+export GITHUB_APP_ID=
 export GITHUB_APP_PEM=
+export GITHUB_TEST_APP_CLIENT_ID=
+export GITHUB_TEST_APP_CLIENT_SECRET=
+export GITHUB_TEST_APP_ID=
+export GITHUB_TEST_APP_PEM=
 export INTERCOM_IDENTITY_SECRET_KEY=
 export POSTMARK_API_KEY=
 export S3_BUCKET=

circle.yml

@@ -17,7 +17,7 @@ test:
       if [ ${CIRCLE_PR_USERNAME} ]; then
         MIX_ENV=test mix test;
       else
-        MIX_ENV=test mix coveralls.circle;
+        MIX_ENV=test mix coveralls.circle --include acceptance:true;
       fi
   post:
     - mix inch.report

config/dev.exs

@@ -7,7 +7,7 @@ use Mix.Config
 # watchers to your application. For example, we use it
 # with brunch.io to recompile .js and .css sources.
 config :code_corps, CodeCorpsWeb.Endpoint,
-  http: [port: 4000, ip: {0, 0, 0, 0, 0, 0, 0, 0}],
+  http: [port: 4000],
   debug_errors: true,
   code_reloader: true,
   check_origin: false

config/test.exs

@@ -41,8 +41,18 @@ config :code_corps, :icon_color_generator, CodeCorps.RandomIconColor.TestGenerat
 # Set Corsica logging to output no console warning when rejecting a request
 config :code_corps, :corsica_log_level, [rejected: :debug]
 
-# Set the GitHub module
-config :code_corps, github: CodeCorps.GitHubTesting
+# fall back to sample pem if none is available as an ENV variable
+pem = case System.get_env("GITHUB_TEST_APP_PEM") do
+  nil -> "./test/fixtures/github/app.pem" |> File.read!
+  encoded_pem -> encoded_pem |> Base.decode64!
+end
+
+config :code_corps,
+  github: CodeCorps.GitHub.SuccessAPI,
+  github_app_id: System.get_env("GITHUB_TEST_APP_ID"),
+  github_app_client_id: System.get_env("GITHUB_TEST_APP_CLIENT_ID"),
+  github_app_client_secret: System.get_env("GITHUB_TEST_APP_CLIENT_SECRET"),
+  github_app_pem: pem
 
 config :sentry,
   environment_name: Mix.env || :test
@@ -57,13 +67,3 @@ config :code_corps,
 
 config :code_corps, :cloudex, CloudexTest
 config :cloudex, api_key: "test_key", secret: "test_secret", cloud_name: "test_cloud_name"
-
-# fall back to sample pem if none is available as an ENV variable
-pem = case System.get_env("GITHUB_APP_PEM") do
-  nil -> "./test/fixtures/github/app.pem" |> File.read!
-  encoded_pem -> encoded_pem |> Base.decode64!
-end
-
-config :code_corps,
-  github: CodeCorps.GitHub.SuccessAPI,
-  github_app_pem: pem

mix.exs

@@ -407,6 +407,7 @@ defmodule CodeCorps.Mixfile do
      "ecto.reset": ["ecto.drop", "ecto.setup"],
      "ecto.migrate": ["ecto.migrate", "ecto.dump"],
      "ecto.rollback": ["ecto.rollback", "ecto.dump"],
-     "test": ["ecto.create --quiet", "ecto.migrate", "test"]]
+     "test": ["ecto.create --quiet", "ecto.migrate", "test"],
+     "test.acceptance": ["ecto.create --quiet", "ecto.migrate", "test --include acceptance:true"]]
   end
 end

test/lib/code_corps/github/api/repository_test.exs

@@ -3,6 +3,8 @@ defmodule CodeCorps.GitHub.API.RepositoryTest do
 
   use CodeCorps.DbAccessCase
 
+  import CodeCorps.GitHub.TestHelpers
+
   alias CodeCorps.{
     GitHub.API.Repository
   }
@@ -33,15 +35,17 @@ defmodule CodeCorps.GitHub.API.RepositoryTest do
       assert Enum.count(issues) == 8
     end
 
+    @tag acceptance: true
     test "calls github API with the real API" do
-      owner = "baxterthehacker"
-      repo = "public-repo"
-      github_app_installation = insert(:github_app_installation, github_account_login: owner)
+      owner = "coderly"
+      repo = "github-app-testing"
+      github_app_installation = insert(:github_app_installation, github_account_login: owner, github_id: 63365)
       github_repo = insert(:github_repo, github_app_installation: github_app_installation, name: repo)
 
-      {:ok, issues} = Repository.issues(github_repo)
-
-      assert Enum.count(issues) == 8
+      with_real_api do
+        {:ok, issues} = Repository.issues(github_repo)
+        assert Enum.count(issues) == 1
+      end
     end
   end
 end

test/test_helper.exs

@@ -3,6 +3,7 @@
 {:ok, _} = Application.ensure_all_started(:ex_machina)
 {:ok, _} = Application.ensure_all_started(:bypass)
 
+ExUnit.configure exclude: [acceptance: true]
 ExUnit.start
 
 Ecto.Adapters.SQL.Sandbox.mode(CodeCorps.Repo, :manual)