Skip to content

Commit 3fb6747

Browse files
author
John Doe
committed
refactor: remove bin options for config generator
1 parent e419189 commit 3fb6747

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

e2e/nx-plugin-e2e/tests/plugin-create-nodes.e2e.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import path from 'node:path';
33
import { readProjectConfiguration } from 'nx/src/generators/utils/project-configuration';
44
import { afterEach, expect } from 'vitest';
55
import { generateCodePushupConfig } from '@code-pushup/nx-plugin';
6+
import { PACKAGE_NAME } from '@code-pushup/nx-plugin/src/internal/constants.js';
67
import {
78
generateWorkspaceAndProject,
89
materializeTree,
@@ -120,7 +121,7 @@ describe('nx-plugin', () => {
120121
expect(projectJson.targets).toStrictEqual({
121122
'code-pushup--configuration': expect.objectContaining({
122123
options: {
123-
command: `nx g XYZ:configuration --project="${project}"`,
124+
command: `nx g ${PACKAGE_NAME}:configuration --project="${project}"`,
124125
},
125126
}),
126127
});

packages/nx-plugin/src/plugin/target/configuration-target.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { PACKAGE_NAME } from '../../internal/constants.js';
55

66
export function createConfigurationTarget(options?: {
77
projectName?: string;
8-
bin?: string;
98
}): TargetConfiguration<RunCommandsOptions> {
109
const { projectName } = options ?? {};
1110
const args = objectToCliArgs({

packages/nx-plugin/src/plugin/target/targets.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ export async function createTargets(normalizedContext: CreateTargetsOptions) {
2929
{
3030
[`${targetName}--configuration`]: createConfigurationTarget({
3131
projectName: normalizedContext.projectJson.name,
32-
bin,
3332
}),
3433
};
3534
}

0 commit comments

Comments
 (0)