refactor(core,ci): handle URL source union type

Author: hanna-skryl

packages/ci/src/lib/issues.ts

@@ -2,19 +2,20 @@ import type {
   Audit,
   AuditReport,
   CategoryRef,
-  Issue,
+  FileIssue,
   PluginMeta,
   Report,
   ReportsDiff,
 } from '@code-pushup/models';
+import { isFileIssue } from '@code-pushup/utils';
 import {
   type ChangedFiles,
   adjustFileName,
   adjustLine,
   isFileChanged,
 } from './git.js';
 
-export type SourceFileIssue = Required<Issue> & IssueContext;
+export type SourceFileIssue = FileIssue & IssueContext;
 
 type IssueContext = {
   audit: Pick<Audit, 'slug' | 'title'>;
@@ -71,7 +72,7 @@ function getAuditIssues(
 ): SourceFileIssue[] {
   return (
     audit.details?.issues
-      ?.filter((issue): issue is Required<Issue> => issue.source?.file != null)
+      ?.filter(isFileIssue)
       .map(issue => ({ ...issue, audit, plugin })) ?? []
   );
 }

packages/core/src/lib/implementation/report-to-gql.ts

@@ -33,6 +33,7 @@ import type {
   TableAlignment,
   Tree,
 } from '@code-pushup/models';
+import { isFileIssue } from '@code-pushup/utils';
 
 export function reportToGQL(
   report: Report,
@@ -106,7 +107,7 @@ export function issueToGQL(issue: Issue): PortalIssue {
   return {
     message: issue.message,
     severity: issueSeverityToGQL(issue.severity),
-    ...(issue.source?.file && {
+    ...(isFileIssue(issue) && {
       sourceType: safeEnum<PortalIssueSourceType>('SourceCode'),
       sourceFilePath: issue.source.file,
       sourceStartLine: issue.source.position?.startLine,

packages/core/src/lib/normalize.ts

@@ -1,18 +1,19 @@
 import type { AuditOutputs, Issue } from '@code-pushup/models';
-import { formatGitPath, getGitRoot } from '@code-pushup/utils';
+import { formatGitPath, getGitRoot, isFileIssue } from '@code-pushup/utils';
 
 export function normalizeIssue(issue: Issue, gitRoot: string): Issue {
+  // Early exit to avoid cloning; only file sources need path normalization
+  if (!isFileIssue(issue)) {
+    return issue;
+  }
   const { source, ...issueWithoutSource } = issue;
-  // early exit to avoid issue object cloning.
-  return source == null
-    ? issue
-    : {
-        ...issueWithoutSource,
-        source: {
-          ...source,
-          file: formatGitPath(source.file, gitRoot),
-        },
-      };
+  return {
+    ...issueWithoutSource,
+    source: {
+      ...source,
+      file: formatGitPath(source.file, gitRoot),
+    },
+  };
 }
 
 export async function normalizeAuditOutputs(