refactor: wip

Author: BioPhoton

packages/utils/docs/profiler.md

@@ -47,7 +47,6 @@ The `Profiler` class provides a clean, type-safe API for performance monitoring
        utils: { track: 'Utils', color: 'primary' },
        core: { track: 'Core', color: 'primary-light' },
      },
-     enabled: true,
    });
    ```
 
@@ -207,7 +206,6 @@ const profiler = new Profiler({
     utils: { track: 'Utils', color: 'primary' },
     core: { track: 'Core', color: 'primary-light' },
   },
-  enabled: true,
 });
 
 // Simple measurement

packages/utils/src/lib/profiler/profiler-node.unit.test.ts

@@ -9,6 +9,7 @@ import {
 import { MockTraceEventFileSink } from '../../../mocks/sink.mock';
 import { subscribeProcessExit } from '../exit-process.js';
 import type { PerformanceEntryEncoder } from '../performance-observer.js';
+import { ID_PATTERNS } from '../process-id.js';
 import type {
   ActionTrackEntryPayload,
   UserTimingDetail,
@@ -33,10 +34,6 @@ const simpleEncoder: PerformanceEntryEncoder<{ message: string }> = entry => {
   return [];
 };
 
-// ─────────────────────────────────────────────────────────────
-// Helper functions
-// ─────────────────────────────────────────────────────────────
-
 const resetEnv = () => {
   // eslint-disable-next-line functional/immutable-data
   delete process.env.DEBUG;
@@ -192,7 +189,6 @@ describe('NodejsProfiler', () => {
     it('should initialize with sink opened when enabled is true', () => {
       const profiler = createProfiler({
         measureName: 'init-enabled',
-        enabled: true,
       });
       expect(profiler.state).toBe('running');
       expect(profiler.stats.shardOpen).toBe(true);
@@ -322,7 +318,6 @@ describe('NodejsProfiler', () => {
     it('is idempotent for repeated operations', () => {
       const profiler = createProfiler({
         measureName: 'idempotent-operations',
-        enabled: true,
       });
 
       profiler.setEnabled(true);
@@ -359,7 +354,6 @@ describe('NodejsProfiler', () => {
     it('should expose shardPath in stats', () => {
       const profiler = createProfiler({
         measureName: 'filepath-getter',
-        enabled: true,
       });
       // When measureName is provided, it's used as the groupId directory
       expect(profiler.stats.shardPath).toContain(
@@ -395,7 +389,6 @@ describe('NodejsProfiler', () => {
     it('should perform measurements when enabled', () => {
       const profiler = createProfiler({
         measureName: 'measurements-enabled',
-        enabled: true,
       });
 
       const result = profiler.measure('test-op', () => 'success');
@@ -424,7 +417,9 @@ describe('NodejsProfiler', () => {
       const stats = profiler.stats;
       // shardPath uses dynamic shard ID format, so we check it matches the pattern
       expect(stats.shardPath).toMatch(
-        /^tmp\/profiles\/stats-getter\/trace\.\d{8}-\d{6}-\d{3}\.\d+\.\d+\.\d+\.jsonl$/,
+        new RegExp(
+          `^tmp/profiles/stats-getter/trace\\.${ID_PATTERNS.INSTANCE_ID.source}\\.jsonl$`,
+        ),
       );
       expect(stats).toStrictEqual({
         profilerState: 'idle',
@@ -454,15 +449,13 @@ describe('NodejsProfiler', () => {
     it('flush() should flush when profiler is running', () => {
       const profiler = createProfiler({
         measureName: 'flush-running',
-        enabled: true,
       });
       expect(() => profiler.flush()).not.toThrow();
     });
 
     it('should propagate errors from measure work function', () => {
       const profiler = createProfiler({
         measureName: 'measure-error',
-        enabled: true,
       });
 
       const error = new Error('Test error');
@@ -476,7 +469,6 @@ describe('NodejsProfiler', () => {
     it('should propagate errors from measureAsync work function', async () => {
       const profiler = createProfiler({
         measureName: 'measure-async-error',
-        enabled: true,
       });
 
       const error = new Error('Async test error');
@@ -605,7 +597,6 @@ describe('NodejsProfiler', () => {
       process.env.DEBUG = 'true';
       const profiler = createProfiler({
         measureName: 'debug-no-transition-marker',
-        enabled: true,
       });
 
       performance.clearMarks();
@@ -683,7 +674,6 @@ describe('NodejsProfiler', () => {
     it('setEnabled toggles profiler state', () => {
       const profiler = createSimpleProfiler({
         measureName: 'exit-set-enabled',
-        enabled: true,
       });
       expect(profiler.isEnabled()).toBe(true);
 
@@ -699,7 +689,6 @@ describe('NodejsProfiler', () => {
       expect(() =>
         createSimpleProfiler({
           measureName: 'exit-uncaught-exception',
-          enabled: true,
         }),
       ).not.toThrow();
 
@@ -731,7 +720,6 @@ describe('NodejsProfiler', () => {
       const handlers = captureExitHandlers();
       const profiler = createSimpleProfiler({
         measureName: 'exit-unhandled-rejection',
-        enabled: true,
       });
       expect(profiler.isEnabled()).toBe(true);
 
@@ -762,7 +750,6 @@ describe('NodejsProfiler', () => {
       const handlers = captureExitHandlers();
       const profiler = createSimpleProfiler({
         measureName: 'exit-handler-shutdown',
-        enabled: true,
       });
       const closeSpy = vi.spyOn(profiler, 'close');
       expect(profiler.isEnabled()).toBe(true);

packages/utils/src/lib/profiler/profiler.int.test.ts

@@ -11,7 +11,6 @@ describe('Profiler Integration', () => {
       tracks: {
         utils: { track: 'Utils', color: 'primary' },
       },
-      enabled: true,
     });
   }
 

packages/utils/src/lib/profiler/profiler.unit.test.ts

@@ -48,7 +48,7 @@ describe('Profiler', () => {
   });
 
   it('constructor should use defaults for measure', () => {
-    const customProfiler = getProfiler({ color: 'secondary', enabled: true });
+    const customProfiler = getProfiler({ color: 'secondary' });
 
     const result = customProfiler.measure('test-operation', () => 'success');
 
@@ -147,7 +147,7 @@ describe('Profiler', () => {
   });
 
   it('marker should execute without error when enabled', () => {
-    const enabledProfiler = getProfiler({ enabled: true });
+    const enabledProfiler = getProfiler();
     expect(() => {
       enabledProfiler.marker('test-marker', {
         color: 'primary',
@@ -175,7 +175,7 @@ describe('Profiler', () => {
   it('marker should execute without error when enabled with default color', () => {
     performance.clearMarks();
 
-    const profilerWithColor = getProfiler({ color: 'primary', enabled: true });
+    const profilerWithColor = getProfiler({ color: 'primary' });
 
     expect(() => {
       profilerWithColor.marker('test-marker-default-color', {
@@ -199,7 +199,7 @@ describe('Profiler', () => {
   });
 
   it('marker should execute without error when enabled with no default color', () => {
-    const profilerNoColor = getProfiler({ enabled: true });
+    const profilerNoColor = getProfiler();
 
     expect(() => {
       profilerNoColor.marker('test-marker-no-color', {
@@ -243,7 +243,7 @@ describe('Profiler', () => {
     performance.clearMarks();
     performance.clearMeasures();
 
-    const enabledProfiler = getProfiler({ enabled: true });
+    const enabledProfiler = getProfiler();
     const workFn = vi.fn(() => 'result');
     const result = enabledProfiler.measure('test-event', workFn, {
       color: 'primary',
@@ -319,7 +319,7 @@ describe('Profiler', () => {
   });
 
   it('measure should propagate errors when enabled and call error callback', () => {
-    const enabledProfiler = getProfiler({ enabled: true });
+    const enabledProfiler = getProfiler();
     const error = new Error('Enabled test error');
     const workFn = vi.fn(() => {
       throw error;
@@ -357,7 +357,7 @@ describe('Profiler', () => {
   });
 
   it('measureAsync should handle async operations correctly when enabled', async () => {
-    const enabledProfiler = getProfiler({ enabled: true });
+    const enabledProfiler = getProfiler();
     const workFn = vi.fn(async () => {
       await Promise.resolve();
       return 'async-result';
@@ -429,7 +429,7 @@ describe('Profiler', () => {
   });
 
   it('measureAsync should propagate async errors when enabled and call error callback', async () => {
-    const enabledProfiler = getProfiler({ enabled: true });
+    const enabledProfiler = getProfiler();
     const error = new Error('Enabled async test error');
     const workFn = vi.fn(async () => {
       await Promise.resolve();