From db25bcfdb7b5afccf9ff6205415ef72eef4a3c0d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Chalk?= Date: Wed, 6 Aug 2025 11:46:22 +0200 Subject: [PATCH] fix(ci): download portal report for base commit and include details --- packages/ci/src/lib/run-utils.ts | 3 +++ packages/ci/src/lib/run.int.test.ts | 9 +++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/ci/src/lib/run-utils.ts b/packages/ci/src/lib/run-utils.ts index 74f2dda5b..ae41c2532 100644 --- a/packages/ci/src/lib/run-utils.ts +++ b/packages/ci/src/lib/run-utils.ts @@ -368,6 +368,7 @@ async function loadCachedBaseReportFromPortal( const { config, env: { settings }, + base, } = args; const { logger } = settings; @@ -381,6 +382,8 @@ async function loadCachedBaseReportFromPortal( parameters: { organization: config.upload.organization, project: config.upload.project, + commit: base.sha, + withDetails: true, }, }).catch((error: unknown) => { logger.warn( diff --git a/packages/ci/src/lib/run.int.test.ts b/packages/ci/src/lib/run.int.test.ts index 8dcda5e95..4b5511188 100644 --- a/packages/ci/src/lib/run.int.test.ts +++ b/packages/ci/src/lib/run.int.test.ts @@ -28,6 +28,7 @@ import { import * as utils from '@code-pushup/utils'; import type { Comment, + GitBranch, GitRefs, Logger, Options, @@ -309,7 +310,7 @@ describe('runInCI', () => { }); describe('pull request event', () => { - let refs: GitRefs; + let refs: { head: GitBranch; base: GitBranch }; let diffMdString: string; beforeEach(async () => { @@ -499,12 +500,16 @@ describe('runInCI', () => { }, } satisfies RunResult); - expect(downloadFromPortal).toHaveBeenCalledWith({ + expect(downloadFromPortal).toHaveBeenCalledWith< + Parameters + >({ server: 'https://api.code-pushup.dunder-mifflin.org/graphql', apiKey: 'cp_abcdef0123456789', parameters: { organization: 'dunder-mifflin', project: 'website', + commit: refs.base.sha, + withDetails: true, }, });