Skip to content

Commit 3e1abcc

Browse files
authored
[tests] Require exact error messages in assertConsole helpers (facebook#35497)
Requires full error message in assert helpers. Some of the error messages we asset on add a native javascript stack trace, which would be a pain to add to the messages and maintain. This PR allows you to just add `\n in <stack>` placeholder to the error message to denote a native stack trace is present in the message. --- Note: i vibe coded this so it was a pain to backtrack this to break this into a stack, I tried and gave up, sorry.
1 parent c186624 commit 3e1abcc

File tree

16 files changed

+690
-320
lines changed

16 files changed

+690
-320
lines changed

.github/workflows/runtime_build_and_test.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -278,6 +278,7 @@ jobs:
278278
if: steps.node_modules.outputs.cache-hit != 'true'
279279
- run: yarn --cwd compiler install --frozen-lockfile
280280
if: steps.node_modules.outputs.cache-hit != 'true'
281+
- run: node --version
281282
- run: yarn test ${{ matrix.params }} --ci --shard=${{ matrix.shard }}
282283

283284
# Hardcoded to improve parallelism
@@ -445,6 +446,7 @@ jobs:
445446
merge-multiple: true
446447
- name: Display structure of build
447448
run: ls -R build
449+
- run: node --version
448450
- run: yarn test --build ${{ matrix.test_params }} --shard=${{ matrix.shard }} --ci
449451

450452
test_build_devtools:
@@ -489,6 +491,7 @@ jobs:
489491
merge-multiple: true
490492
- name: Display structure of build
491493
run: ls -R build
494+
- run: node --version
492495
- run: yarn test --build --project=devtools -r=experimental --shard=${{ matrix.shard }} --ci
493496

494497
process_artifacts_combined:

0 commit comments

Comments
 (0)