Fix (#85)

Author: Juliya Smith

src/code42cli/cmds/detectionlists/high_risk_employee.py

@@ -21,7 +21,7 @@ class HighRiskEmployeeSubcommandLoader(DetectionListSubcommandLoader):
     def __init__(self, root_command_name):
         super(HighRiskEmployeeSubcommandLoader, self).__init__(root_command_name)
         handlers = _create_handlers()
-        self.detection_list = DetectionList.create_departing_employee_list(handlers)
+        self.detection_list = DetectionList.create_high_risk_employee_list(handlers)
         self._cmd_loader = self.detection_list.subcommand_loader
 
     def load_commands(self):

tests/cmds/detectionlists/test_departing_employee.py

@@ -1,10 +1,10 @@
 import pytest
-import logging
 
 from code42cli.errors import UserAlreadyAddedError, UserDoesNotExistError
 from code42cli.cmds.detectionlists.departing_employee import (
     add_departing_employee,
     remove_departing_employee,
+    DepartingEmployeeSubcommandLoader,
 )
 
 from .conftest import TEST_ID
@@ -15,6 +15,20 @@
 _EMPLOYEE = "departing employee"
 
 
+class TestDepartingEmployeeSubcommandLoader(object):
+    def test_load_subcommands_loads_expected_commands(self):
+        loader = DepartingEmployeeSubcommandLoader("test")
+        cmds = loader.load_commands()
+        names = [cmd.name for cmd in cmds]
+        assert "add" in names
+        assert "bulk" in names
+        assert "remove" in names
+    
+    def test_loader_has_expected_detection_list_name(self):
+        loader = DepartingEmployeeSubcommandLoader("test")
+        assert "departing-employee" == loader.detection_list.name
+
+
 def test_add_departing_employee_when_given_cloud_alias_adds_alias(sdk_with_user, profile):
     alias = "departing employee alias"
     add_departing_employee(sdk_with_user, profile, _EMPLOYEE, cloud_alias=[alias])

tests/cmds/detectionlists/test_high_risk_employee.py

@@ -4,6 +4,7 @@
 from code42cli.cmds.detectionlists.high_risk_employee import (
     add_high_risk_employee,
     remove_high_risk_employee,
+    HighRiskEmployeeSubcommandLoader,
 )
 
 from code42cli.cmds.detectionlists.enums import RiskTags
@@ -15,6 +16,20 @@
 _EMPLOYEE = "risky employee"
 
 
+class TestHighRiskEmployeeSubcommandLoader(object):
+    def test_load_subcommands_loads_expected_commands(self):
+        loader = HighRiskEmployeeSubcommandLoader("test")
+        cmds = loader.load_commands()
+        names = [cmd.name for cmd in cmds]
+        assert "add" in names
+        assert "bulk" in names
+        assert "remove" in names
+
+    def test_loader_has_expected_detection_list_name(self):
+        loader = HighRiskEmployeeSubcommandLoader("test")
+        assert "high-risk-employee" == loader.detection_list.name
+
+
 def test_add_high_risk_employee_when_given_cloud_alias_adds_alias(sdk_with_user, profile):
     alias = "risk employee alias"
     add_high_risk_employee(sdk_with_user, profile, _EMPLOYEE, cloud_alias=alias)

tests/test_completer.py

@@ -16,47 +16,58 @@ def test_complete_for_profile(self):
     def test_complete_for_security_data(self):
         actual = self._completer.complete("code42 security")
         assert "security-data" in actual
+        assert len(actual) == 1
 
     def test_complete_for_alert_and_rules(self):
         actual = self._completer.complete("code42 al")
         assert "alerts" in actual
         assert "alert-rules" in actual
-
+        assert len(actual) == 2
+        
     def test_complete_for_departing_employee(self):
         actual = self._completer.complete("code42 de")
         assert "departing-employee" in actual
+        assert len(actual) == 1
 
     def test_complete_for_high_risk_employee(self):
         actual = self._completer.complete("code42 hi")
         assert "high-risk-employee" in actual
+        assert len(actual) == 1
 
     def test_profile_create(self):
         actual = self._completer.complete("code42 profile cre")
         assert "create" in actual
-
+        assert len(actual) == 1
+        
     def test_complete_for_high_risk_employee_bulk(self):
         actual = self._completer.complete("code42 high-risk-employee bu")
         assert "bulk" in actual
+        assert len(actual) == 1
 
     def test_complete_for_departing_employee_bulk(self):
         actual = self._completer.complete("code42 departing-employee bu")
         assert "bulk" in actual
+        assert len(actual) == 1
 
     def test_complete_for_alert_rules_bulk(self):
         actual = self._completer.complete("code42 alert-rules b")
         assert "bulk" in actual
+        assert len(actual) == 1
 
     def test_complete_for_high_risk_employee_bulk_gen_template(self):
         actual = self._completer.complete("code42 high-risk-employee bulk gen")
         assert "generate-template" in actual
+        assert len(actual) == 1
 
     def test_complete_for_departing_employee_bulk_gen_template(self):
         actual = self._completer.complete("code42 departing-employee bulk generate-")
         assert "generate-template" in actual
+        assert len(actual) == 1
 
     def test_complete_for_alert_rules_bulk_gen_template(self):
         actual = self._completer.complete("code42 alert-rules bulk gen")
         assert "generate-template" in actual
+        assert len(actual) == 1
 
     def test_complete_when_arg_is_first_and_complete_returns_first_set_of_options(self):
         actual = self._completer.complete("code42 ")