handle windows log error from ssl connection (#231)

Author: Juliya Smith

src/code42cli/logger/handlers.py

@@ -11,7 +11,11 @@ class SyslogServerNetworkConnectionError(Exception):
     """An error raised when the connection is disrupted during logging."""
 
     def __init__(self):
-        super().__init__("Network connection broken while sending results.")
+        super().__init__(
+            "The network connection broke while sending results. "
+            "This might happen if your connection requires TLS and you are attempting "
+            "unencrypted TCP communication."
+        )
 
 
 class NoPrioritySysLogHandler(SysLogHandler):
@@ -85,7 +89,7 @@ def handleError(self, record):
         them nowhere.
         """
         t, _, _ = sys.exc_info()
-        if t == BrokenPipeError:
+        if issubclass(t, ConnectionError):
             raise SyslogServerNetworkConnectionError()
         super().handleError(record)
 

tests/logger/test_handlers.py

@@ -49,10 +49,20 @@ def socket_mocks(mocker):
 
 
 @pytest.fixture()
-def broken_pipe_error(mocker):
-    mock_exc_info = mocker.patch("code42cli.logger.handlers.sys.exc_info")
-    mock_exc_info.return_value = (BrokenPipeError, None, None)
-    return mock_exc_info
+def system_exception_info(mocker):
+    return mocker.patch("code42cli.logger.handlers.sys.exc_info")
+
+
+@pytest.fixture()
+def broken_pipe_error(system_exception_info):
+    system_exception_info.return_value = (BrokenPipeError, None, None)
+    return system_exception_info
+
+
+@pytest.fixture()
+def connection_reset_error(system_exception_info):
+    system_exception_info.return_value = (ConnectionResetError, None, None)
+    return system_exception_info
 
 
 def _get_normal_socket_initializer_mocks(mocker, new_socket):
@@ -204,7 +214,7 @@ def test_emit_when_udp_calls_socket_sendto_with_expected_message_and_address(
             expected_message, (_TEST_HOST, _TEST_PORT)
         )
 
-    def test_handle_error_raises_expected_error(
+    def test_handle_error_when_broken_pipe_error_occurs_raises_expected_error(
         self, mock_file_event_log_record, broken_pipe_error
     ):
         handler = NoPrioritySysLogHandler(
@@ -213,6 +223,15 @@ def test_handle_error_raises_expected_error(
         with pytest.raises(SyslogServerNetworkConnectionError):
             handler.handleError(mock_file_event_log_record)
 
+    def test_handle_error_when_connection_reset_error_occurs_raises_expected_error(
+        self, mock_file_event_log_record, connection_reset_error
+    ):
+        handler = NoPrioritySysLogHandler(
+            _TEST_HOST, _TEST_PORT, ServerProtocol.UDP, None
+        )
+        with pytest.raises(SyslogServerNetworkConnectionError):
+            handler.handleError(mock_file_event_log_record)
+
     def test_close_when_using_tls_unwraps_socket(self):
         handler = NoPrioritySysLogHandler(
             _TEST_HOST, _TEST_PORT, ServerProtocol.TLS_TCP, None