Fix list subcommand headers and make cases show display all fields in table format (#211)

Author: kiran-chaudhary

src/code42cli/cmds/cases.py

@@ -20,7 +20,7 @@
 name_option = click.option("--name", help="Name of the case.",)
 assignee_option = click.option("--assignee", help="User UID of the assignee.")
 description_option = click.option("--description", help="Description of the case.")
-notes_option = click.option("--notes", help="Notes on the case.")
+findings_option = click.option("--findings", help="Findings on the case.")
 subject_option = click.option("--subject", help="User UID of a subject of the case.")
 status_option = click.option(
     "--status",
@@ -42,15 +42,16 @@ def _get_cases_header():
         "name": "Name",
         "assignee": "Assignee",
         "status": "Status",
+        "subject": "Subject",
         "createdAt": "Creation Time",
-        "findings": "Notes",
+        "updatedAt": "Last Update Time",
     }
 
 
 def _get_events_header():
     return {
         "eventId": "Event Id",
-        "eventTimestatmp": "Timestamp",
+        "eventTimestamp": "Timestamp",
         "filePath": "Path",
         "fileName": "File",
         "exposure": "Exposure",
@@ -68,17 +69,17 @@ def cases(state):
 @click.argument("name")
 @assignee_option
 @description_option
-@notes_option
+@findings_option
 @subject_option
 @sdk_options()
-def create(state, name, subject, assignee, description, notes):
+def create(state, name, subject, assignee, description, findings):
     """Create a new case."""
     state.sdk.cases.create(
         name,
         subject=subject,
         assignee=assignee,
         description=description,
-        findings=notes,
+        findings=findings,
     )
 
 
@@ -87,19 +88,19 @@ def create(state, name, subject, assignee, description, notes):
 @name_option
 @assignee_option
 @description_option
-@notes_option
+@findings_option
 @subject_option
 @status_option
 @sdk_options()
-def update(state, case_number, name, subject, assignee, description, notes, status):
+def update(state, case_number, name, subject, assignee, description, findings, status):
     """Update case details for the given case."""
     state.sdk.cases.update(
         case_number,
         name=name,
         subject=subject,
         assignee=assignee,
         description=description,
-        findings=notes,
+        findings=findings,
         status=status,
     )
 
@@ -172,7 +173,7 @@ def _display_file_events(events):
 @format_option
 def show(state, case_number, format, include_file_events):
     """Show case details."""
-    formatter = OutputFormatter(format, _get_cases_header())
+    formatter = OutputFormatter(format)
     try:
         response = state.sdk.cases.get(case_number)
         formatter.echo_formatted_list([response.data])

tests/cmds/test_cases.py

@@ -10,18 +10,28 @@
 from code42cli.main import cli
 
 
-EVENT_DETAILS = """{"eventId": "0_1d71796f-af5b-4231-9d8e-df6434da4663_984418168383179707_986472527798692818_971"}
-"""
-
-ALL_EVENTS = """{"events": [{"eventId": "0_1d71796f-af5b-4231-9d8e-df6434da4663_984418168383179707_986472527798692818_971"}]}"""
-
-ALL_CASES = """{"cases": [{"number": 3,"name": "test@test.test"}], "totalCount": 31}"""
-
-CASE_DETAILS = """{"number": 3, "name": "test@test.test"}"""
-
+ALL_EVENTS = """{
+  "events": [
+    {
+      "eventId": "0_1d71796f-af5b-4231-9d8e-df6434da4663_984418168383179707_986472527798692818_971",
+      "eventTimestamp": "2020-12-23T12:41:38.592Z"
+    }
+  ]
+}"""
+ALL_CASES = """{
+  "cases": [
+    {
+      "number": 3,
+      "name": "test@test.test",
+      "updatedAt": "2021-01-24T11:00:04.217878Z",
+      "subject": "942897"
+    }
+  ],
+  "totalCount": 31
+}"""
+CASE_DETAILS = '{"number": 3, "name": "test@test.test"}'
 CASES_COMMAND = "cases"
 CASES_FILE_EVENTS_COMMAND = "cases file-events"
-
 MISSING_ARGUMENT_ERROR = "Missing argument '{}'."
 MISSING_NAME = MISSING_ARGUMENT_ERROR.format("NAME")
 MISSING_CASE_NUMBER = MISSING_ARGUMENT_ERROR.format("CASE_NUMBER")
@@ -63,7 +73,7 @@ def test_create_with_optional_fields_calls_create_with_expected_params(
             "a",
             "--description",
             "d",
-            "--notes",
+            "--findings",
             "n",
             "--subject",
             "s",
@@ -90,7 +100,7 @@ def test_update_with_optional_fields_calls_update_with_expected_params(
             "a",
             "--description",
             "d",
-            "--notes",
+            "--findings",
             "n",
             "--subject",
             "s",
@@ -227,6 +237,8 @@ def gen():
     cli_state.sdk.cases.get_all.return_value = gen()
     result = runner.invoke(cli, ["cases", "list"], obj=cli_state,)
     assert "test@test.test" in result.output
+    assert "2021-01-24T11:00:04.217878Z" in result.output
+    assert "942897" in result.output
 
 
 def test_show_returns_expected_data_with_include_file_events_option(
@@ -250,6 +262,7 @@ def test_events_list_returns_expected_data(runner, cli_state):
         "0_1d71796f-af5b-4231-9d8e-df6434da4663_984418168383179707_986472527798692818_971"
         in result.output
     )
+    assert "2020-12-23T12:41:38.592Z" in result.output
 
 
 @pytest.mark.parametrize(