Bugfix/windows unicode with pipes (#338)

* add handling of UnicodeEncodeError

* use explicit newlines so on Windows it doesn't get doubled

* output real unicode in json

* clarify error message

* update error msg again

Author: timabrmsn

src/code42cli/click_ext/groups.py

@@ -1,4 +1,5 @@
 import difflib
+import platform
 import re
 from collections import OrderedDict
 
@@ -100,6 +101,15 @@ def invoke(self, ctx):
             self.logger.log_verbose_error(self._original_args, err.response.request)
             raise LoggedCLIError("Problem making request to server.")
 
+        except UnicodeEncodeError:
+            if platform.system() == "Windows":
+                cmd = '$ENV:PYTHONIOENCODING="utf-16"'
+            else:
+                cmd = 'export PYTHONIOENCODING="utf-8"'
+            raise Code42CLIError(
+                f"Failed to handle unicode character using environment's detected encoding, try running:\n\n  {cmd}\n\nand then re-run your `code42` command."
+            )
+
         except OSError:
             raise
 

src/code42cli/output_formats.py

@@ -96,6 +96,7 @@ def get_formatted_output(self, df, **kwargs):
                 "orient": "records",
                 "lines": True,
                 "index": True,
+                "force_ascii": False,
                 "default_handler": str,
             }
             defaults.update(kwargs)
@@ -106,13 +107,14 @@ def get_formatted_output(self, df, **kwargs):
                 "orient": "records",
                 "lines": False,
                 "index": True,
+                "force_ascii": False,
                 "default_handler": str,
             }
             defaults.update(kwargs)
             return df.to_json(**defaults)
 
         elif self.output_format == OutputFormat.CSV:
-            defaults = {"index": False}
+            defaults = {"index": False, "line_terminator": "\n"}
             defaults.update(kwargs)
             df = df.fillna("")
             return df.to_csv(**defaults)