Skip to content

Commit 7268e48

Browse files
authored
Don't prompt to set password on profile update when it's already set (#248)
* don't prompt to set password when it's already set * fix tests
1 parent ee0136d commit 7268e48

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/code42cli/cmds/profile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def update(name, server, username, password, disable_ssl_errors):
107107
cliprofile.update_profile(c42profile.name, server, username, disable_ssl_errors)
108108
if password:
109109
_set_pw(name, password)
110-
else:
110+
elif not c42profile.has_stored_password:
111111
_prompt_for_allow_password_set(c42profile.name)
112112
echo("Profile '{}' has been updated.".format(c42profile.name))
113113

tests/cmds/test_profile.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,7 @@ def test_update_profile_if_credentials_invalid_password_not_saved(
310310
):
311311
name = "foo"
312312
profile.name = name
313+
profile.has_stored_password = False
313314
mock_cliprofile_namespace.get_profile.return_value = profile
314315

315316
result = runner.invoke(
@@ -335,6 +336,7 @@ def test_update_profile_if_user_agrees_and_valid_connection_sets_password(
335336
):
336337
name = "foo"
337338
profile.name = name
339+
profile.has_stored_password = False
338340
mock_cliprofile_namespace.get_profile.return_value = profile
339341
runner.invoke(
340342
cli,

0 commit comments

Comments
 (0)