Skip to content

Commit 82a9e15

Browse files
author
Juliya Smith
authored
Show correct profile name when resetting default (#162)
* Show correct profile name when resetting default * Fix test names * Add new failing test * Add new test
1 parent e8846ad commit 82a9e15

File tree

2 files changed

+19
-4
lines changed

2 files changed

+19
-4
lines changed

src/code42cli/cmds/profile.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,8 @@ def reset_pw(profile_name):
102102
Change the stored password for a profile. Only affects what's stored in the local profile,
103103
does not make any changes to the Code42 user account."""
104104
password = getpass()
105-
_set_pw(profile_name, password)
106-
echo("Password updated for profile '{}'".format(profile_name))
105+
profile_name_saved = _set_pw(profile_name, password)
106+
echo("Password updated for profile '{}'.".format(profile_name_saved))
107107

108108

109109
@profile.command("list")
@@ -171,3 +171,4 @@ def _set_pw(profile_name, password):
171171
secho("Password not stored!", bold=True)
172172
raise
173173
cliprofile.set_password(password, c42profile.name)
174+
return c42profile.name

tests/cmds/test_profile.py

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ def test_delete_all_deletes_all_existing_profiles(
390390
mock_cliprofile_namespace.delete_profile.assert_any_call("test2")
391391

392392

393-
def test_prompt_for_password_reset_if_credentials_valid_password_saved(
393+
def test_reset_pw_if_credentials_valid_password_saved(
394394
runner, mocker, user_agreement, mock_verify, mock_cliprofile_namespace
395395
):
396396
mock_verify.return_value = True
@@ -401,7 +401,7 @@ def test_prompt_for_password_reset_if_credentials_valid_password_saved(
401401
)
402402

403403

404-
def test_prompt_for_password_reset_if_credentials_invalid_password_not_saved(
404+
def test_reset_pw_if_credentials_invalid_password_not_saved(
405405
runner, user_agreement, mock_verify, mock_cliprofile_namespace
406406
):
407407
mock_verify.side_effect = Code42CLIError("Invalid credentials for user")
@@ -410,6 +410,20 @@ def test_prompt_for_password_reset_if_credentials_invalid_password_not_saved(
410410
assert not mock_cliprofile_namespace.set_password.call_count
411411

412412

413+
def test_reset_pw_uses_default_profile_when_not_given_one(
414+
runner, mocker, user_agreement, mock_verify, mock_cliprofile_namespace
415+
):
416+
mock_verify.return_value = True
417+
mock_cliprofile_namespace.profile_exists.return_value = False
418+
mock_profile = create_mock_profile("one")
419+
mock_cliprofile_namespace.get_profile.return_value = mock_profile
420+
res = runner.invoke(cli, ["profile", "reset-pw"])
421+
mock_cliprofile_namespace.set_password.assert_called_once_with(
422+
"newpassword", mocker.ANY
423+
)
424+
assert "Password updated for profile 'one'." in res.output
425+
426+
413427
def test_list_profiles(runner, mock_cliprofile_namespace):
414428
profiles = [
415429
create_mock_profile("one"),

0 commit comments

Comments
 (0)