Raise exception instead of echo in alert-rules add when rule-id is invalid (#223)

* raise exception in alert-rules add instead of echo

* added changelog

* fixed changelog

Author: kiran-chaudhary

CHANGELOG.md

@@ -20,6 +20,10 @@ how a consumer would use the library (e.g. adding unit tests, updating documenta
     - `cases file-events add` sets an event id that is already added to the case.
     - `cases file-events remove` is performed on an already closed case.
 
+### Fixed
+
+- Issue where `code42 alert-rules bulk add` would show as successful when adding users to a non-existent alert rule.
+
 ### Added
 
 - New choice `TLS-TCP` for `--protocol` option used by `send-to` commands:

src/code42cli/cmds/alert_rules.py

@@ -183,7 +183,7 @@ def _handle_rules_results(rules, rule_id=None):
     if not rules:
         id_msg = "with RuleId {} ".format(rule_id) if rule_id else ""
         msg = "No alert rules {}found.".format(id_msg)
-        echo(msg)
+        raise Code42CLIError(msg)
     return rules
 
 

tests/cmds/test_alert_rules.py

@@ -169,7 +169,7 @@ def test_add_user_when_rule_not_found_prints_expected_output(mocker, runner, cli
         ["alert-rules", "add-user", "--rule-id", TEST_RULE_ID, "-u", TEST_USERNAME],
         obj=cli_state,
     )
-    assert "No alert rules with RuleId rule-id found." in result.output
+    assert "Error: No alert rules with RuleId rule-id found." in result.output
 
 
 def test_remove_user_removes_user_list_from_alert_rules(runner, cli_state):