Skip to content

Commit d59753f

Browse files
authored
Fix/init sdk before bulk processing (#109)
* remove `write-to` and `send-to` and rename `print` to `search` on alerts/security-data cmds * remove unused loggers * update tests * fix case where exception is printed on KeyboardInterrupt and closed pipe. * update readme and changelog * add TCP examples * remove tests for removed func * remove tests for removed loggers * fix bug from change in latest py42 * add note about external tools for more complex requirements * initalize sdk before passing to bulk func so it doesn't get initialized in each separate thread * updated docs
1 parent 66d42cc commit d59753f

File tree

4 files changed

+20
-14
lines changed

4 files changed

+20
-14
lines changed

src/code42cli/cmds/alert_rules.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,8 @@ def bulk(state):
112112
@read_csv_arg(headers=ALERT_RULES_CSV_HEADERS)
113113
@sdk_options
114114
def add(state, csv_rows):
115-
row_handler = lambda rule_id, username: _add_user(state.sdk, rule_id, username)
115+
sdk = state.sdk
116+
row_handler = lambda rule_id, username: _add_user(sdk, rule_id, username)
116117
run_bulk_process(row_handler, csv_rows, progress_label="Adding users to alert-rules:")
117118

118119

@@ -124,7 +125,8 @@ def add(state, csv_rows):
124125
@read_csv_arg(headers=ALERT_RULES_CSV_HEADERS)
125126
@sdk_options
126127
def remove(state, csv_rows):
127-
row_handler = lambda rule_id, username: _remove_user(state.sdk, rule_id, username)
128+
sdk = state.sdk
129+
row_handler = lambda rule_id, username: _remove_user(sdk, rule_id, username)
128130
run_bulk_process(row_handler, csv_rows, progress_label="Removing users from alert-rules:")
129131

130132

src/code42cli/cmds/departing_employee.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,9 @@ def bulk(state):
6262
@read_csv_arg(headers=DEPARTING_EMPLOYEE_CSV_HEADERS)
6363
@sdk_options
6464
def add(state, csv_rows):
65+
sdk = state.sdk
6566
row_handler = lambda username, cloud_alias, departure_date, notes: _add_departing_employee(
66-
state.sdk, username, cloud_alias, departure_date, notes
67+
sdk, username, cloud_alias, departure_date, notes
6768
)
6869
run_bulk_process(
6970
row_handler, csv_rows, progress_label="Adding users to departing employee detection list:"
@@ -77,7 +78,8 @@ def add(state, csv_rows):
7778
@read_flat_file_arg
7879
@sdk_options
7980
def remove(state, file_rows):
80-
row_handler = lambda username: _remove_departing_employee(state.sdk, username)
81+
sdk = state.sdk
82+
row_handler = lambda username: _remove_departing_employee(sdk, username)
8183
run_bulk_process(
8284
row_handler,
8385
file_rows,

src/code42cli/cmds/high_risk_employee.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,9 @@ def bulk(state):
101101
@read_csv_arg(headers=HIGH_RISK_EMPLOYEE_CSV_HEADERS)
102102
@sdk_options
103103
def add(state, csv_rows):
104+
sdk = state.sdk
104105
row_handler = lambda username, cloud_alias, risk_tag, notes: _add_high_risk_employee(
105-
state.sdk, username, cloud_alias, risk_tag, notes
106+
sdk, username, cloud_alias, risk_tag, notes
106107
)
107108
run_bulk_process(
108109
row_handler, csv_rows, progress_label="Adding users to high risk employee detection list:"
@@ -116,7 +117,8 @@ def add(state, csv_rows):
116117
@read_flat_file_arg
117118
@sdk_options
118119
def remove(state, file_rows):
119-
row_handler = lambda username: _remove_high_risk_employee(state.sdk, username)
120+
sdk = state.sdk
121+
row_handler = lambda username: _remove_high_risk_employee(sdk, username)
120122
run_bulk_process(
121123
row_handler,
122124
file_rows,
@@ -132,7 +134,8 @@ def remove(state, file_rows):
132134
@read_csv_arg(headers=RISK_TAG_CSV_HEADERS)
133135
@sdk_options
134136
def add_risk_tags(state, csv_rows):
135-
row_handler = lambda username, tag: _add_risk_tags(state.sdk, username, tag)
137+
sdk = state.sdk
138+
row_handler = lambda username, tag: _add_risk_tags(sdk, username, tag)
136139
run_bulk_process(
137140
row_handler, csv_rows, progress_label="Adding risk tags to users:",
138141
)
@@ -146,7 +149,8 @@ def add_risk_tags(state, csv_rows):
146149
@read_csv_arg(headers=RISK_TAG_CSV_HEADERS)
147150
@sdk_options
148151
def remove_risk_tags(state, csv_rows):
149-
row_handler = lambda username, tag: _remove_risk_tags(state.sdk, username, tag)
152+
sdk = state.sdk
153+
row_handler = lambda username, tag: _remove_risk_tags(sdk, username, tag)
150154
run_bulk_process(
151155
row_handler, csv_rows, progress_label="Removing risk tags from users:",
152156
)

src/code42cli/cmds/legal_hold.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,8 @@ def bulk(state):
139139
@read_csv_arg(headers=LEGAL_HOLD_CSV_HEADERS)
140140
@sdk_options
141141
def add(state, csv_rows):
142-
row_handler = lambda matter_id, username: _add_user_to_legal_hold(
143-
state.sdk, matter_id, username
144-
)
142+
sdk = state.sdk
143+
row_handler = lambda matter_id, username: _add_user_to_legal_hold(sdk, matter_id, username)
145144
run_bulk_process(row_handler, csv_rows, progress_label="Adding users to legal hold:")
146145

147146

@@ -153,9 +152,8 @@ def add(state, csv_rows):
153152
@read_csv_arg(headers=LEGAL_HOLD_CSV_HEADERS)
154153
@sdk_options
155154
def remove(state, csv_rows):
156-
row_handler = lambda matter_id, username: _remove_user_from_legal_hold(
157-
state.sdk, matter_id, username
158-
)
155+
sdk = state.sdk
156+
row_handler = lambda matter_id, username: _remove_user_from_legal_hold(sdk, matter_id, username)
159157
run_bulk_process(row_handler, csv_rows, progress_label="Removing users from legal hold:")
160158

161159

0 commit comments

Comments
 (0)