[CM-997] Add linter rules and fix warnings

Author: Mark Pospesel

.swiftlint.yml

@@ -9,6 +9,8 @@ opt_in_rules: # some rules are turned off by default, so you need to opt-in
   - empty_count
   - first_where
   - force_unwrapping
+  - implicit_return
+  - missing_docs
   - multiline_arguments
   - multiline_arguments_brackets
   - multiline_function_chains

Sources/YComponentBrowser/CatalogFactory.swift

@@ -45,7 +45,7 @@ public enum CatalogFactory {
         with categories: [Classification],
         navigationTitle: String? = nil
     ) -> UIViewController {
-        return ClassificationViewController(
+        ClassificationViewController(
             datasource: ClassificationDataSource(
                 navigationTitle: navigationTitle,
                 classification: categories

Sources/YComponentBrowser/ClassificationScene/ClassificationDataSource.swift

@@ -34,12 +34,12 @@ public final class ClassificationDataSource: NSObject, CatalogDataSource {
 
     /// :nodoc:
     public func category(for indexPath: IndexPath) -> Classification {
-        return categories[indexPath.row]
+        categories[indexPath.row]
     }
 
     /// :nodoc:
     public func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
-        return categories.count
+        categories.count
     }
 
     /// :nodoc:

Sources/YComponentBrowser/ClassificationScene/ClassificationViewController.swift

@@ -21,7 +21,7 @@ public final class ClassificationViewController<DataSource: CatalogDataSource>:
     }
 
     /// :nodoc:
-    public required init?(coder: NSCoder) { return nil }
+    public required init?(coder: NSCoder) { nil }
 
     /// :nodoc:
     public override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {

Sources/YComponentBrowser/Models/Destinations/CatalogDetailDestination.swift

@@ -19,7 +19,7 @@ public struct CatalogDetailDestination<View: ContentView>: Destination {
 
     /// Creates a tableview controller that displays the model data within the specified view
     public func getDestinationController() -> UIViewController {
-        return CatalogFactory.createGenericDisplayViewController(
+        CatalogFactory.createGenericDisplayViewController(
             viewType: View.self,
             models: models,
             navigationTitle: navigationTitle

Sources/YComponentBrowser/Models/Destinations/SubcategoryDetailDestination.swift

@@ -19,6 +19,6 @@ public struct SubcategoryDetailDestination: Destination {
 
     /// Creates a subcategory view controller
     public func getDestinationController() -> UIViewController {
-        return CatalogFactory.createClassificationViewController(with: subcategories, navigationTitle: navigationTitle)
+        CatalogFactory.createClassificationViewController(with: subcategories, navigationTitle: navigationTitle)
     }
 }

Sources/YComponentBrowser/Protocols/Identifiable.swift

@@ -15,5 +15,5 @@ public protocol Identifiable {
 /// Default implementation that returns the object type as the identifier
 public extension Identifiable {
     /// Unique identifier for the type of object
-    static var identifier: String { return "\(self)" }
+    static var identifier: String { "\(self)" }
 }

Sources/YComponentBrowser/UI Components/Generic Cells/GenericCollectionViewCell.swift

@@ -39,7 +39,7 @@ public final class GenericCollectionViewCell<View: ContentView>: UICollectionVie
     }
 
     /// :nodoc:
-    public required init?(coder: NSCoder) { return nil }
+    public required init?(coder: NSCoder) { nil }
 
     /// :nodoc:
     public override func prepareForReuse() {

Sources/YComponentBrowser/UI Components/Generic Cells/GenericTableViewCell.swift

@@ -21,9 +21,7 @@ public final class GenericTableViewCell<View: ContentView>: UITableViewCell, Ide
     }
 
     /// :nodoc:
-    public required init?(coder: NSCoder) {
-        return nil
-    }
+    public required init?(coder: NSCoder) { nil }
 
     /// :nodoc:
     public override func setHighlighted(_ highlighted: Bool, animated: Bool) {

Sources/YComponentBrowser/UI Components/Generic Controllers/GenericCollectionViewController.swift

@@ -37,7 +37,7 @@ final public class GenericCollectionViewController<View: ContentView>: UICollect
         _ collectionView: UICollectionView,
         numberOfItemsInSection section: Int
     ) -> Int {
-        return models.count
+        models.count
     }
 
     /// :nodoc: