fix: prevent hanging in Playwright acceptance tests with terminal error handling

- Add terminal error detection for ERR_ABORTED and frame detachment errors
- Prevent infinite retries for unrecoverable navigation failures
- Improve screenshot plugin error handling with browser state checks
- Reduce screenshot timeout from 30s to 5s for faster failure
- Add terminal error handling in recorder to immediately re-throw fatal errors
- Enhance retryFailedStep plugin to skip terminal navigation errors

Fixes hanging issues in Playwright acceptance tests when frames are detached
or browser connections are lost during iframe/within operations.

Author: kobenguyent

lib/helper/Playwright.js

@@ -1026,7 +1026,18 @@ class Playwright extends Helper {
       throw new Error(`Page is not initialized after auto-initialization. this.page=${this.page}, this.isRunning=${this.isRunning}, this.browser=${!!this.browser}, this.browserContext=${!!this.browserContext}`)
     }
 
-    await this.page.goto(url, { waitUntil: this.options.waitForNavigation })
+    try {
+      await this.page.goto(url, { waitUntil: this.options.waitForNavigation })
+    } catch (err) {
+      // Handle terminal navigation errors that shouldn't be retried
+      if (err.message && (err.message.includes('ERR_ABORTED') || err.message.includes('frame was detached') || err.message.includes('Target page, context or browser has been closed'))) {
+        // Mark this as a terminal error to prevent retries
+        const terminalError = new Error(err.message)
+        terminalError.isTerminal = true
+        throw terminalError
+      }
+      throw err
+    }
 
     const performanceTiming = JSON.parse(await this.page.evaluate(() => JSON.stringify(window.performance.timing)))
 

lib/plugin/retryFailedStep.js

@@ -88,6 +88,10 @@ export default function (config) {
     if (!enableRetry) return
     if (store.debugMode) return false
     if (!store.autoRetries) return false
+    // Don't retry terminal errors (e.g., frame detachment errors)
+    if (err && err.isTerminal) return false
+    // Don't retry navigation errors that are known to be terminal
+    if (err && err.message && (err.message.includes('ERR_ABORTED') || err.message.includes('frame was detached') || err.message.includes('Target page, context or browser has been closed'))) return false
     if (customWhen) return customWhen(err)
     return true
   }

lib/plugin/screenshotOnFail.js

@@ -122,10 +122,18 @@ export default function (config) {
             }
           }
 
-          // Add timeout wrapper to prevent hanging
+          // Check if browser/page is still available before attempting screenshot
+          if (helper.page && helper.page.isClosed && helper.page.isClosed()) {
+            throw new Error('Browser page has been closed')
+          }
+          if (helper.browser && helper.browser.isConnected && !helper.browser.isConnected()) {
+            throw new Error('Browser has been disconnected')
+          }
+
+          // Add timeout wrapper to prevent hanging with shorter timeout for ESM
           const screenshotPromise = helper.saveScreenshot(fileName, options.fullPageScreenshots)
           const timeoutPromise = new Promise((_, reject) => {
-            setTimeout(() => reject(new Error('Screenshot timeout after 30 seconds')), 30000)
+            setTimeout(() => reject(new Error('Screenshot timeout after 5 seconds')), 5000)
           })
 
           await Promise.race([screenshotPromise, timeoutPromise])
@@ -184,8 +192,19 @@ export default function (config) {
           if (!quietMode) {
             output.plugin('screenshotOnFail', `Failed to save screenshot: ${err.message}`)
           }
-          if (err && err.type && err.type === 'RuntimeError' && err.message && (err.message.indexOf('was terminated due to') > -1 || err.message.indexOf('no such window: target window already closed') > -1)) {
-            output.log(`Can't make screenshot, ${err}`)
+          // Enhanced error handling for browser closed scenarios
+          if (
+            err &&
+            ((err.message &&
+              (err.message.includes('Target page, context or browser has been closed') ||
+                err.message.includes('Browser page has been closed') ||
+                err.message.includes('Browser has been disconnected') ||
+                err.message.includes('was terminated due to') ||
+                err.message.includes('no such window: target window already closed') ||
+                err.message.includes('Screenshot timeout after'))) ||
+              (err.type && err.type === 'RuntimeError'))
+          ) {
+            output.log(`Can't make screenshot, ${err.message}`)
             helper.isRunning = false
           }
         }

lib/recorder.js

@@ -279,6 +279,13 @@ export default {
     if (!promise) promise = Promise.resolve()
     return (promise = promise.catch(err => {
       if (ignoredErrs.includes(err)) return // already caught
+
+      // Handle terminal errors - don't continue, re-throw immediately
+      if (err && (err.isTerminal || (err.message && (err.message.includes('ERR_ABORTED') || err.message.includes('frame was detached') || err.message.includes('Target page, context or browser has been closed'))))) {
+        output.log(`${currentQueue()} Terminal Error | ${err} | ${fnDescription || ''}...`)
+        throw err // Re-throw terminal errors immediately
+      }
+
       output.log(`${currentQueue()} Error (Non-Terminated) | ${err} | ${fnDescription || ''}...`)
       if (!(err instanceof Error)) {
         // strange things may happen