fix : naming convention session / main erasing with long test.title/tags

julien-ft-64 · julien-ft-64 · commit 26a99b40a3e2 · 2025-05-14T12:33:26.000+02:00
fix: context is funtion in session and not property
fix : dual saving main session
diff --git a/lib/helper/Playwright.js b/lib/helper/Playwright.js
@@ -2377,15 +2377,16 @@ class Playwright extends Helper {
     if (this.options.recordVideo && this.page && this.page.video()) {
       test.artifacts.video = saveVideoForPage(this.page, `${test.title}.failed`)
       for (const sessionName in this.sessionPages) {
-        test.artifacts[`video_${sessionName}`] = saveVideoForPage(this.sessionPages[sessionName], `${test.title}_${sessionName}.failed`)
+        if (sessionName === '') continue
+        test.artifacts[`video_${sessionName}`] = saveVideoForPage(this.sessionPages[sessionName], `${sessionName}_${test.title}.failed`)
       }
     }
 
     if (this.options.trace) {
       test.artifacts.trace = await saveTraceForContext(this.browserContext, `${test.title}.failed`)
       for (const sessionName in this.sessionPages) {
-        if (!this.sessionPages[sessionName].context) continue
-        test.artifacts[`trace_${sessionName}`] = await saveTraceForContext(this.sessionPages[sessionName].context, `${test.title}_${sessionName}.failed`)
+        if (!this.sessionPages[sessionName].context || sessionName === '') continue
+        test.artifacts[`trace_${sessionName}`] = await saveTraceForContext(this.sessionPages[sessionName].context(), `${sessionName}_${test.title}.failed`)
       }
     }
 
@@ -2399,7 +2400,8 @@ class Playwright extends Helper {
       if (this.options.keepVideoForPassedTests) {
         test.artifacts.video = saveVideoForPage(this.page, `${test.title}.passed`)
         for (const sessionName of Object.keys(this.sessionPages)) {
-          test.artifacts[`video_${sessionName}`] = saveVideoForPage(this.sessionPages[sessionName], `${test.title}_${sessionName}.passed`)
+          if (sessionName === '') continue
+          test.artifacts[`video_${sessionName}`] = saveVideoForPage(this.sessionPages[sessionName], `${sessionName}_${test.title}.passed`)
         }
       } else {
         this.page
@@ -2414,8 +2416,8 @@ class Playwright extends Helper {
         if (this.options.trace) {
           test.artifacts.trace = await saveTraceForContext(this.browserContext, `${test.title}.passed`)
           for (const sessionName in this.sessionPages) {
-            if (!this.sessionPages[sessionName].context) continue
-            test.artifacts[`trace_${sessionName}`] = await saveTraceForContext(this.sessionPages[sessionName].context, `${test.title}_${sessionName}.passed`)
+            if (!this.sessionPages[sessionName].context || sessionName === '') continue
+            test.artifacts[`trace_${sessionName}`] = await saveTraceForContext(this.sessionPages[sessionName].context(), `${sessionName}_${test.title}.passed`)
           }
         }
       } else {

Original file line number	Diff line number	Diff line change
`@@ -2377,15 +2377,16 @@ class Playwright extends Helper {`
`2377`	`2377`	`if (this.options.recordVideo && this.page && this.page.video()) {`
`2378`	`2378`	test.artifacts.video = saveVideoForPage(this.page, `${test.title}.failed`)
`2379`	`2379`	`for (const sessionName in this.sessionPages) {`
`2380`		- test.artifacts[`video_${sessionName}`] = saveVideoForPage(this.sessionPages[sessionName], `${test.title}_${sessionName}.failed`)
	`2380`	`+ if (sessionName === '') continue`
	`2381`	+ test.artifacts[`video_${sessionName}`] = saveVideoForPage(this.sessionPages[sessionName], `${sessionName}_${test.title}.failed`)
`2381`	`2382`	`}`
`2382`	`2383`	`}`
`2383`	`2384`
`2384`	`2385`	`if (this.options.trace) {`
`2385`	`2386`	test.artifacts.trace = await saveTraceForContext(this.browserContext, `${test.title}.failed`)
`2386`	`2387`	`for (const sessionName in this.sessionPages) {`
`2387`		`- if (!this.sessionPages[sessionName].context) continue`
`2388`		- test.artifacts[`trace_${sessionName}`] = await saveTraceForContext(this.sessionPages[sessionName].context, `${test.title}_${sessionName}.failed`)
	`2388`	`+ if (!this.sessionPages[sessionName].context \|\| sessionName === '') continue`
	`2389`	+ test.artifacts[`trace_${sessionName}`] = await saveTraceForContext(this.sessionPages[sessionName].context(), `${sessionName}_${test.title}.failed`)
`2389`	`2390`	`}`
`2390`	`2391`	`}`
`2391`	`2392`
`@@ -2399,7 +2400,8 @@ class Playwright extends Helper {`
`2399`	`2400`	`if (this.options.keepVideoForPassedTests) {`
`2400`	`2401`	test.artifacts.video = saveVideoForPage(this.page, `${test.title}.passed`)
`2401`	`2402`	`for (const sessionName of Object.keys(this.sessionPages)) {`
`2402`		- test.artifacts[`video_${sessionName}`] = saveVideoForPage(this.sessionPages[sessionName], `${test.title}_${sessionName}.passed`)
	`2403`	`+ if (sessionName === '') continue`
	`2404`	+ test.artifacts[`video_${sessionName}`] = saveVideoForPage(this.sessionPages[sessionName], `${sessionName}_${test.title}.passed`)
`2403`	`2405`	`}`
`2404`	`2406`	`} else {`
`2405`	`2407`	`this.page`
`@@ -2414,8 +2416,8 @@ class Playwright extends Helper {`
`2414`	`2416`	`if (this.options.trace) {`
`2415`	`2417`	test.artifacts.trace = await saveTraceForContext(this.browserContext, `${test.title}.passed`)
`2416`	`2418`	`for (const sessionName in this.sessionPages) {`
`2417`		`- if (!this.sessionPages[sessionName].context) continue`
`2418`		- test.artifacts[`trace_${sessionName}`] = await saveTraceForContext(this.sessionPages[sessionName].context, `${test.title}_${sessionName}.passed`)
	`2419`	`+ if (!this.sessionPages[sessionName].context \|\| sessionName === '') continue`
	`2420`	+ test.artifacts[`trace_${sessionName}`] = await saveTraceForContext(this.sessionPages[sessionName].context(), `${sessionName}_${test.title}.passed`)
`2419`	`2421`	`}`
`2420`	`2422`	`}`
`2421`	`2423`	`} else {`