fix tests

Author: kobenguyent

lib/command/workers/runTests.js

@@ -69,9 +69,15 @@ const config = deepMerge(getConfig(options.config || testRoot), overrideConfigs)
 
   filterTests()
 
-  // run tests
+  // run tests, or gracefully finish if none left after filtering
   if (mocha.suite.total()) {
     await runTests()
+  } else {
+    // still need to notify parent about result and close port
+    initializeListeners()
+    disablePause()
+    event.dispatcher.emit(event.all.result, container.result())
+    parentPort?.close()
   }
 })()
 

lib/mocha/asyncWrapper.js

@@ -61,24 +61,26 @@ function test(test) {
     recorder.startUnlessRunning()
     // Fire started event immediately so listeners are notified regardless of recorder queue
     event.emit(event.test.started, test)
+    let failed = false
     recorder.errHandler(err => {
+      failed = true
       recorder.session.start('teardown')
       recorder.cleanAsyncErr()
       if (test.throws) {
         // check that test should actually fail
         try {
           assertThrown(err, test.throws)
           event.emit(event.test.passed, test)
-          event.emit(event.test.finished, test)
+          // finished is emitted in teardown after hooks complete
           recorder.add(doneFn)
           return
         } catch (newErr) {
           err = newErr
         }
       }
+      // mark error on test, emit failed now; finished will be emitted later in teardown
       test.err = err
       event.emit(event.test.failed, test, err)
-      event.emit(event.test.finished, test)
       recorder.add(() => doneFn(err))
     })
 
@@ -90,9 +92,11 @@ function test(test) {
       if (isAsyncFunction(testFn)) await res
     })
     recorder.add('restore test session', () => recorder.session.restore('test'))
+    // Only after session is restored (i.e., all inner tasks finished) and no failure happened, mark test as passed
     recorder.add('fire test.passed', () => {
+      if (failed) return
       event.emit(event.test.passed, test)
-      event.emit(event.test.finished, test)
+      // finished is emitted in teardown after hooks complete
     })
     recorder.add('finish test', doneFn)
     recorder.catch()
@@ -191,7 +195,10 @@ function teardown(suite) {
     recorder.startUnlessRunning()
     const testModule = await import('./test.js')
     const { enhanceMochaTest } = testModule.default || testModule
-    event.emit(event.test.after, enhanceMochaTest(suite?.ctx?.currentTest))
+  const currentTest = enhanceMochaTest(suite?.ctx?.currentTest)
+  event.emit(event.test.after, currentTest)
+  // emit finished after after-hook so parent can count pass/fail reliably
+  event.emit(event.test.finished, currentTest, currentTest.err)
   }, suite)
 }
 

lib/workers.js

@@ -244,6 +244,9 @@ class Workers extends EventEmitter {
     this.testGroups = []
     this.config = config
     this.numberOfWorkersRequested = numberOfWorkers
+  // Track emitted pass events to avoid double-counting duplicates from retries/race conditions
+  this._passedUids = new Set()
+  this._pendingPass = new Set()
 
     createOutputDir(config.testConfig)
     // Defer worker initialization until codecept is ready
@@ -252,7 +255,7 @@ class Workers extends EventEmitter {
   async _ensureInitialized() {
     if (!this.codecept) {
       this.codecept = await this.codeceptPromise
-      if (this.numberOfWorkersRequested) {
+  if (typeof this.numberOfWorkersRequested === 'number' && this.numberOfWorkersRequested > 0) {
         this._initWorkers(this.numberOfWorkersRequested, this.config)
       }
     }
@@ -298,6 +301,10 @@ class Workers extends EventEmitter {
    */
   spawn() {
     const worker = new WorkerObject(this.numberOfWorkers)
+    // Default testRoot to the configured testConfig location for manual spawns
+    if (this.config?.testConfig) {
+      worker.setTestRoot(this.config.testConfig)
+    }
     this.workers.push(worker)
     this.numberOfWorkers += 1
     return worker
@@ -307,7 +314,9 @@ class Workers extends EventEmitter {
    * @param {Number} numberOfWorkers
    */
   createGroupsOfTests(numberOfWorkers) {
-    const files = this.codecept.testFiles
+  // If Codecept isn't initialized yet, return empty groups as a safe fallback
+  if (!this.codecept) return populateGroups(numberOfWorkers)
+  const files = this.codecept.testFiles
     const mocha = Container.mocha()
     mocha.files = files
     mocha.loadFiles()
@@ -329,7 +338,9 @@ class Workers extends EventEmitter {
    * @param {Number} numberOfWorkers
    */
   createGroupsOfSuites(numberOfWorkers) {
-    const files = this.codecept.testFiles
+  // If Codecept isn't initialized yet, return empty groups as a safe fallback
+  if (!this.codecept) return populateGroups(numberOfWorkers)
+  const files = this.codecept.testFiles
     const groups = populateGroups(numberOfWorkers)
 
     const mocha = Container.mocha()
@@ -423,15 +434,25 @@ class Workers extends EventEmitter {
           this.emit(event.test.started, deserializeTest(message.data))
           break
         case event.test.failed:
+          if (message?.data?.uid) this._pendingPass.delete(message.data.uid)
           this.emit(event.test.failed, deserializeTest(message.data))
           break
         case event.test.passed:
-          this.emit(event.test.passed, deserializeTest(message.data))
+          // Buffer pass until finished to avoid counting tests that will fail later
+          if (message?.data?.uid) this._pendingPass.add(message.data.uid)
           break
         case event.test.skipped:
           this.emit(event.test.skipped, deserializeTest(message.data))
           break
         case event.test.finished:
+          // Emit a deduped 'passed' only if it was pending and no error provided
+          if (message?.data?.uid && !message?.data?.err) {
+            if (!this._passedUids.has(message.data.uid) && this._pendingPass.has(message.data.uid)) {
+              this._passedUids.add(message.data.uid)
+              this.emit(event.test.passed, deserializeTest(message.data))
+            }
+          }
+          if (message?.data?.uid) this._pendingPass.delete(message.data.uid)
           this.emit(event.test.finished, deserializeTest(message.data))
           break
         case event.test.after:

test/unit/worker_test.js

@@ -226,7 +226,7 @@ describe('Workers', function () {
       testConfig: './test/data/sandbox/codecept.non-test-events-worker.js',
     }
 
-    workers = new Workers(2, workerConfig)
+  let workers = new Workers(2, workerConfig)
 
     workers.run()