fixed setting name for test

Author: DavertMik

lib/mocha/test.js

@@ -51,18 +51,6 @@ function enhanceMochaTest(test) {
     test.uid = genTestId(test)
   }
 
-  test.toFileName = function () {
-    let fileName = clearString(test.title)
-    if (fileName.indexOf('{') !== -1) {
-      fileName = fileName.substr(0, fileName.indexOf('{') - 3).trim()
-    }
-    // TODO: add suite title to file name
-    // if (test.parent && test.parent.title) {
-    //   fileName = `${clearString(test.parent.title)}_${fileName}`
-    // }
-    return fileName
-  }
-
   test.applyOptions = function (opts) {
     if (!opts) opts = {}
     test.opts = opts
@@ -134,8 +122,22 @@ function cloneTest(test) {
   return deserializeTest(serializeTest(test))
 }
 
+function testToFileName(test) {
+  let fileName = clearString(test.title)
+  if (fileName.indexOf('{') !== -1) {
+    fileName = fileName.substr(0, fileName.indexOf('{') - 3).trim()
+  }
+  if (test.ctx && test.ctx.test && test.ctx.test.type === 'hook') fileName = clearString(`${test.title}_${test.ctx.test.title}`)
+  // TODO: add suite title to file name
+  // if (test.parent && test.parent.title) {
+  //   fileName = `${clearString(test.parent.title)}_${fileName}`
+  // }
+  return fileName
+}
+
 module.exports = {
   createTest,
+  testToFileName,
   enhanceMochaTest,
   serializeTest,
   deserializeTest,

lib/plugin/pageInfo.js

@@ -7,7 +7,7 @@ const supportedHelpers = require('./standardActingHelpers')
 const { scanForErrorMessages } = require('../html')
 const { output } = require('..')
 const { humanizeString, ucfirst } = require('../utils')
-
+const { testToFileName } = require('../mocha/test')
 const defaultConfig = {
   errorClasses: ['error', 'warning', 'alert', 'danger'],
   browserLogs: ['error'],
@@ -95,7 +95,7 @@ module.exports = function (config = {}) {
     recorder.add('Save page info', () => {
       test.addNote('pageInfo', pageStateToMarkdown(pageState))
 
-      const pageStateFileName = path.join(global.output_dir, `${test.toFileName()}.pageInfo.md`)
+      const pageStateFileName = path.join(global.output_dir, `${testToFileName(test)}.pageInfo.md`)
       fs.writeFileSync(pageStateFileName, pageStateToMarkdown(pageState))
       test.artifacts.pageInfo = pageStateFileName
       return pageState

lib/plugin/screenshotOnFail.js

@@ -5,8 +5,9 @@ const Container = require('../container')
 const recorder = require('../recorder')
 const event = require('../event')
 const output = require('../output')
-const { fileExists, clearString } = require('../utils')
+const { fileExists } = require('../utils')
 const Codeceptjs = require('../index')
+const { testToFileName } = require('../mocha/test')
 
 const defaultConfig = {
   uniqueScreenshotNames: false,
@@ -81,9 +82,8 @@ module.exports = function (config) {
       async () => {
         const dataType = 'image/png'
         // This prevents data driven to be included in the failed screenshot file name
-        let fileName = test.toFileName()
+        let fileName = testToFileName(test)
 
-        if (test.ctx && test.ctx.test && test.ctx.test.type === 'hook') fileName = clearString(`${test.title}_${test.ctx.test.title}`)
         if (options.uniqueScreenshotNames && test) {
           const uuid = _getUUID(test)
           fileName = `${fileName.substring(0, 10)}_${uuid}.failed.png`