fix: prevent Playwright tests from hanging when BROWSER_RESTART=browser

- Add timeout protection to _afterSuite() and _cleanup() methods
- Fix restart strategy detection in lib/listener/helpers.js to include 'browser' and 'session' restart modes
- Add teardown timeout (10s) and force exit (500ms) in run command
- Skip _finishTest and _cleanup hooks when browser restart is enabled

This prevents double cleanup and hanging when using BROWSER_RESTART=browser env variable.
Tests now complete and exit properly instead of hanging indefinitely.

Author: kobenguyent

lib/command/run.js

@@ -41,20 +41,28 @@ export default async function (test, options) {
     printError(err)
     process.exitCode = 1
   } finally {
-    await codecept.teardown()
+    // Add timeout to teardown to prevent hanging
+    const teardownPromise = codecept.teardown()
+    const teardownTimeout = new Promise((_, reject) => 
+      setTimeout(() => reject(new Error('Teardown timeout')), 10000)
+    )
 
-    // Force exit if event loop doesn't clear naturally
-    // This is needed because some helpers (like Playwright) may leave handles open
-    // even after proper cleanup, preventing natural process termination
+    try {
+      await Promise.race([teardownPromise, teardownTimeout])
+    } catch (e) {
+      if (e.message === 'Teardown timeout') {
+        console.warn('Teardown timed out after 10 seconds, forcing exit')
+      } else {
+        console.warn('Teardown error:', e.message)
+      }
+    }
+    
+    // Force exit immediately after teardown completes or times out
     if (!options.noExit) {
-      // Use beforeExit to ensure we run after all other exit handlers (including Mocha's)
-      // have set the correct exit code
-      process.once('beforeExit', (code) => {
-        // Give cleanup a moment to complete, then force exit with the correct code
-        setTimeout(() => {
-          process.exit(code || process.exitCode || 0)
-        }, 100)
-      })
+      // Give a very short grace period then force exit
+      setTimeout(() => {
+        process.exit(process.exitCode || 0)
+      }, 500)
     }
   }
 }

lib/helper/Playwright.js

@@ -808,12 +808,20 @@ class Playwright extends Helper {
     // For session mode (restart:false): stop after the last suite
     if (this.isRunning) {
       try {
-        await this._stopBrowser()
+        // Add timeout protection to prevent hanging
+        await Promise.race([
+          this._stopBrowser(),
+          new Promise((_, reject) => setTimeout(() => reject(new Error('Browser stop timeout in afterSuite')), 10000)),
+        ])
       } catch (e) {
         console.warn('Warning during suite cleanup:', e.message)
         // Track suite cleanup failures
         this.hasCleanupError = true
         this.testFailures.push(`Suite cleanup failed: ${e.message}`)
+        // Force cleanup on timeout
+        this.browser = null
+        this.browserContext = null
+        this.isRunning = false
       } finally {
         this.isRunning = false
       }
@@ -914,17 +922,32 @@ class Playwright extends Helper {
     // Final cleanup when test run completes
     if (this.isRunning) {
       try {
-        await this._stopBrowser()
+        // Add timeout protection to prevent hanging
+        await Promise.race([
+          this._stopBrowser(),
+          new Promise((_, reject) => setTimeout(() => reject(new Error('Browser stop timeout in cleanup')), 10000)),
+        ])
       } catch (e) {
         console.warn('Warning during final cleanup:', e.message)
+        // Force cleanup on timeout
+        this.browser = null
+        this.browserContext = null
+        this.isRunning = false
       }
     } else {
       // Check if we still have a browser object despite isRunning being false
       if (this.browser) {
         try {
-          await this._stopBrowser()
+          // Add timeout protection to prevent hanging
+          await Promise.race([
+            this._stopBrowser(),
+            new Promise((_, reject) => setTimeout(() => reject(new Error('Browser stop timeout in forced cleanup')), 10000)),
+          ])
         } catch (e) {
           console.warn('Warning during forced cleanup:', e.message)
+          // Force cleanup on timeout
+          this.browser = null
+          this.browserContext = null
         }
       }
     }

lib/listener/helpers.js

@@ -74,7 +74,10 @@ export default function () {
 
   event.dispatcher.on(event.all.result, () => {
     // Skip _finishTest for all helpers if any browser helper restarts to avoid double cleanup
-    const hasBrowserRestart = Object.values(helpers).some(helper => (helper.config && helper.config.restart) || (helper.options && helper.options.restart === 'context'))
+    const hasBrowserRestart = Object.values(helpers).some(helper => 
+      (helper.config && (helper.config.restart === 'browser' || helper.config.restart === 'context' || helper.config.restart === true)) || 
+      (helper.options && (helper.options.restart === 'browser' || helper.options.restart === 'context' || helper.options.restart === true))
+    )
 
     Object.keys(helpers).forEach(key => {
       const helper = helpers[key]
@@ -86,7 +89,10 @@ export default function () {
 
   event.dispatcher.on(event.all.after, () => {
     // Skip _cleanup for all helpers if any browser helper restarts to avoid double cleanup
-    const hasBrowserRestart = Object.values(helpers).some(helper => (helper.config && helper.config.restart) || (helper.options && helper.options.restart === 'context'))
+    const hasBrowserRestart = Object.values(helpers).some(helper => 
+      (helper.config && (helper.config.restart === 'browser' || helper.config.restart === 'context' || helper.config.restart === true)) || 
+      (helper.options && (helper.options.restart === 'browser' || helper.options.restart === 'context' || helper.options.restart === true))
+    )
 
     Object.keys(helpers).forEach(key => {
       const helper = helpers[key]