removed dep on chai in JSONResponse

Author: DavertMik

lib/helper/JSONResponse.js

@@ -1,9 +1,5 @@
 const Helper = require('@codeceptjs/helper')
-
-const chai = require('chai')
-
-const expect = chai.expect
-chai.use(require('chai-deep-match'))
+const assert = require('assert')
 const joi = require('joi')
 
 /**
@@ -107,7 +103,7 @@ class JSONResponse extends Helper {
    */
   seeResponseCodeIs(code) {
     this._checkResponseReady()
-    expect(this.response.status).to.eql(code, 'Response code is not the same as expected')
+    assert.strictEqual(this.response.status, code, 'Response code is not the same as expected')
   }
 
   /**
@@ -121,34 +117,31 @@ class JSONResponse extends Helper {
    */
   dontSeeResponseCodeIs(code) {
     this._checkResponseReady()
-    expect(this.response.status).not.to.eql(code)
+    assert.notStrictEqual(this.response.status, code)
   }
 
   /**
    * Checks that the response code is 4xx
    */
   seeResponseCodeIsClientError() {
     this._checkResponseReady()
-    expect(this.response.status).to.be.gte(400)
-    expect(this.response.status).to.be.lt(500)
+    assert(this.response.status >= 400 && this.response.status < 500)
   }
 
   /**
    * Checks that the response code is 3xx
    */
   seeResponseCodeIsRedirection() {
     this._checkResponseReady()
-    expect(this.response.status).to.be.gte(300)
-    expect(this.response.status).to.be.lt(400)
+    assert(this.response.status >= 300 && this.response.status < 400)
   }
 
   /**
    * Checks that the response code is 5xx
    */
   seeResponseCodeIsServerError() {
     this._checkResponseReady()
-    expect(this.response.status).to.be.gte(500)
-    expect(this.response.status).to.be.lt(600)
+    assert(this.response.status >= 500 && this.response.status < 600)
   }
 
   /**
@@ -161,8 +154,7 @@ class JSONResponse extends Helper {
    */
   seeResponseCodeIsSuccessful() {
     this._checkResponseReady()
-    expect(this.response.status).to.be.gte(200)
-    expect(this.response.status).to.be.lt(300)
+    assert(this.response.status >= 200 && this.response.status < 300)
   }
 
   /**
@@ -185,17 +177,19 @@ class JSONResponse extends Helper {
   seeResponseContainsJson(json = {}) {
     this._checkResponseReady()
     if (Array.isArray(this.response.data)) {
-      let fails = 0
+      let found = false
       for (const el of this.response.data) {
         try {
-          expect(el).to.deep.match(json)
+          this._assertContains(el, json)
+          found = true
+          break
         } catch (err) {
-          fails++
+          continue
         }
       }
-      expect(fails < this.response.data.length, `No elements in array matched ${JSON.stringify(json)}`).to.be.true
+      assert(found, `No elements in array matched ${JSON.stringify(json)}`)
     } else {
-      expect(this.response.data).to.deep.match(json)
+      this._assertContains(this.response.data, json)
     }
   }
 
@@ -219,9 +213,22 @@ class JSONResponse extends Helper {
   dontSeeResponseContainsJson(json = {}) {
     this._checkResponseReady()
     if (Array.isArray(this.response.data)) {
-      this.response.data.forEach((data) => expect(data).not.to.deep.match(json))
+      for (const data of this.response.data) {
+        try {
+          this._assertContains(data, json)
+          assert.fail(`Found matching element: ${JSON.stringify(data)}`)
+        } catch (err) {
+          // expected to fail
+          continue
+        }
+      }
     } else {
-      expect(this.response.data).not.to.deep.match(json)
+      try {
+        this._assertContains(this.response.data, json)
+        assert.fail('Response contains the JSON')
+      } catch (err) {
+        // expected to fail
+      }
     }
   }
 
@@ -247,28 +254,35 @@ class JSONResponse extends Helper {
   seeResponseContainsKeys(keys = []) {
     this._checkResponseReady()
     if (Array.isArray(this.response.data)) {
-      this.response.data.forEach((data) => expect(data).to.include.keys(keys))
+      for (const data of this.response.data) {
+        for (const key of keys) {
+          assert(key in data, `Key "${key}" is not found in ${JSON.stringify(data)}`)
+        }
+      }
     } else {
-      expect(this.response.data).to.include.keys(keys)
+      for (const key of keys) {
+        assert(key in this.response.data, `Key "${key}" is not found in ${JSON.stringify(this.response.data)}`)
+      }
     }
   }
 
   /**
-   * Executes a callback function passing in `response` object and chai assertions with `expect`
+   * Executes a callback function passing in `response` object and assert
    * Use it to perform custom checks of response data
    *
    * ```js
-   * I.seeResponseValidByCallback(({ data, status, expect }) => {
-   *   expect(status).to.eql(200);
-   *   expect(data).keys.to.include(['user', 'company']);
+   * I.seeResponseValidByCallback(({ data, status }) => {
+   *   assert.strictEqual(status, 200);
+   *   assert('user' in data);
+   *   assert('company' in data);
    * });
    * ```
    *
    * @param {function} fn
    */
   seeResponseValidByCallback(fn) {
     this._checkResponseReady()
-    fn({ ...this.response, expect })
+    fn({ ...this.response, assert })
     const body = fn.toString()
     fn.toString = () => `${body.split('\n')[1]}...`
   }
@@ -285,7 +299,7 @@ class JSONResponse extends Helper {
    */
   seeResponseEquals(resp) {
     this._checkResponseReady()
-    expect(this.response.data).to.deep.equal(resp)
+    assert.deepStrictEqual(this.response.data, resp)
   }
 
   /**
@@ -332,6 +346,17 @@ class JSONResponse extends Helper {
   _checkResponseReady() {
     if (!this.response) throw new Error('Response is not available')
   }
+
+  _assertContains(actual, expected) {
+    for (const key in expected) {
+      assert(key in actual, `Key "${key}" not found in ${JSON.stringify(actual)}`)
+      if (typeof expected[key] === 'object' && expected[key] !== null) {
+        this._assertContains(actual[key], expected[key])
+      } else {
+        assert.deepStrictEqual(actual[key], expected[key], `Values for key "${key}" don't match`)
+      }
+    }
+  }
 }
 
 module.exports = JSONResponse