fix bugs

Author: kobenguyent

lib/container.js

@@ -32,7 +32,7 @@ let container = {
   translation: {},
   /** @type {Result | null} */
   result: null,
-  sharedKeys: new Set() // Track keys shared via share() function
+  sharedKeys: new Set(), // Track keys shared via share() function
 }
 
 /**
@@ -202,6 +202,15 @@ class Container {
   static append(newContainer) {
     container = deepMerge(container, newContainer)
 
+    // If new helpers are added, set the helpers property on them
+    if (newContainer.helpers) {
+      for (const name in newContainer.helpers) {
+        if (container.helpers[name] && typeof container.helpers[name] === 'object') {
+          container.helpers[name].helpers = container.helpers
+        }
+      }
+    }
+
     // If new support objects are added, update the proxy support
     if (newContainer.support) {
       const newProxySupport = createSupportObjects(newContainer.support)
@@ -250,10 +259,10 @@ class Container {
     // Instead of using append which replaces the entire container,
     // directly update the support object to maintain proxy references
     Object.assign(container.support, data)
-    
+
     // Track which keys were explicitly shared
     Object.keys(data).forEach(key => container.sharedKeys.add(key))
-    
+
     if (!options.local) {
       WorkerStorage.share(data)
     }
@@ -349,6 +358,16 @@ async function createHelpers(config) {
     }
   }
 
+  // Set helpers property on each helper to allow access to other helpers
+  for (const name in helpers) {
+    if (helpers[name] && typeof helpers[name] === 'object') {
+      helpers[name].helpers = helpers
+    }
+  }
+
+  // Wait for async helpers and call _init
+  await asyncHelperPromise
+
   for (const name in helpers) {
     if (helpers[name]._init) await helpers[name]._init()
   }
@@ -677,24 +696,23 @@ async function loadSupportObject(modulePath, supportObjectName) {
     // Use dynamic import for both ESM and CJS modules
     let importPath = modulePath
     let tempJsFile = null
-    
+
     if (typeof importPath === 'string') {
       const ext = path.extname(importPath)
-      
+
       // Handle TypeScript files
       if (ext === '.ts') {
         try {
           // Use the TypeScript transpilation utility
           const typescript = await import('typescript')
           const { tempFile, allTempFiles } = await transpileTypeScript(importPath, typescript)
-          
+
           debug(`Transpiled TypeScript file: ${importPath} -> ${tempFile}`)
-          
+
           // Attach cleanup handler
           importPath = tempFile
           // Store temp files list in a way that cleanup can access them
           tempJsFile = allTempFiles
-          
         } catch (tsError) {
           throw new Error(`Failed to load TypeScript file ${importPath}: ${tsError.message}. Make sure 'typescript' package is installed.`)
         }
@@ -703,7 +721,7 @@ async function loadSupportObject(modulePath, supportObjectName) {
         importPath = `${importPath}.js`
       }
     }
-    
+
     let obj
     try {
       obj = await import(importPath)

test/rest/REST_test.js

@@ -140,7 +140,7 @@ describe('REST', () => {
     let jsonResponse
 
     beforeEach(async () => {
-      Container.create({
+      await Container.create({
         helpers: {
           REST: {},
           JSONResponse: {},

test/unit/bdd_test.js

@@ -55,10 +55,10 @@ const checkTestForErrors = test => {
 }
 
 describe('BDD', () => {
-  beforeEach(() => {
+  beforeEach(async () => {
     clearSteps()
     recorder.start()
-    container.create({})
+    await container.create({})
     Config.reset()
   })
 

test/unit/container_test.js

@@ -161,7 +161,7 @@ describe('Container', () => {
           FileSystem: {},
         },
       }
-      container.create(config)
+      await container.create(config)
       await container.started()
       // custom helpers
       expect(container.helpers('MyHelper')).is.ok
@@ -266,7 +266,7 @@ describe('Container', () => {
           FileSystem: {},
         },
       }
-      container.create(config)
+      await container.create(config)
       await container.started()
       container.append({
         helpers: {
@@ -294,10 +294,10 @@ describe('Container', () => {
       const tsStepsPath = path.join(__dirname, '../data/typescript-support/steps_file.ts')
       await container.create({
         include: {
-          I: tsStepsPath
-        }
+          I: tsStepsPath,
+        },
       })
-      
+
       const I = container.support('I')
       expect(I).to.be.ok
       expect(I.testMethod).to.be.a('function')
@@ -309,10 +309,10 @@ describe('Container', () => {
       const tsStepsPath = path.join(__dirname, '../data/typescript-support/steps_file.ts')
       await container.create({
         include: {
-          I: tsStepsPath
-        }
+          I: tsStepsPath,
+        },
       })
-      
+
       const I = container.support('I')
       // Note: These are proxied through MetaStep, so we can't call them directly in tests
       // The test verifies that the file loads and the structure is correct
@@ -325,10 +325,10 @@ describe('Container', () => {
       const tsStepsPath = path.join(__dirname, '../data/typescript-support/steps_with_dirname.ts')
       await container.create({
         include: {
-          I: tsStepsPath
-        }
+          I: tsStepsPath,
+        },
       })
-      
+
       const I = container.support('I')
       expect(I).to.be.ok
       expect(I.getConfigPath).to.be.a('function')
@@ -340,10 +340,10 @@ describe('Container', () => {
       const tsStepsPath = path.join(__dirname, '../data/typescript-support/steps_with_require.ts')
       await container.create({
         include: {
-          I: tsStepsPath
-        }
+          I: tsStepsPath,
+        },
       })
-      
+
       const I = container.support('I')
       expect(I).to.be.ok
       expect(I.getPluginPath).to.be.a('function')

test/unit/mocha/asyncWrapper_test.js

@@ -21,9 +21,7 @@ describe('AsyncWrapper', () => {
     test.fn = fn
     await Container.create({
       helpers: {
-        TestHelper: {
-          testMethod: () => 'test result',
-        },
+        FileSystem: {},
       },
     })
   })