fixed Playwright tests

Author: DavertMik

lib/command/check.js

@@ -73,7 +73,7 @@ export default async function (options) {
       const files = codecept.testFiles
       const mocha = Container.mocha()
       mocha.files = files
-      mocha.loadFiles()
+      await mocha.loadFiles()
 
       for (const suite of mocha.suite.suites) {
         if (suite && suite.tests) {

lib/mocha/factory.js

@@ -39,7 +39,7 @@ class MochaFactory {
       process.exit(1)
     }
 
-    mocha.loadFiles = fn => {
+    mocha.loadFiles = async fn => {
       // load features
       if (mocha.suite.suites.length === 0) {
         const featureFiles = mocha.files.filter(file => file.match(/\.feature$/))
@@ -49,18 +49,31 @@ class MochaFactory {
         }
 
         // remove feature files
+        const jsFiles = mocha.files.filter(file => !file.match(/\.feature$/))
         mocha.files = mocha.files.filter(file => !file.match(/\.feature$/))
 
-        // In ESM context, tests may already be loaded during codecept initialization
-        // Only call original Mocha loadFiles if no suites exist yet
-        if (mocha.suite.suites.length === 0) {
+        // Load JavaScript test files using ESM imports
+        if (jsFiles.length > 0) {
           try {
+            // Try original loadFiles first for compatibility
             Mocha.prototype.loadFiles.call(mocha, fn)
           } catch (e) {
-            // If original loadFiles fails (e.g., ESM compatibility issues),
-            // skip it since tests may already be loaded through codecept
-            if (e.message.includes('getStatus') || e.message.includes('ESM')) {
-              console.warn('Skipping Mocha.prototype.loadFiles due to ESM compatibility issues')
+            // If original loadFiles fails, load ESM files manually
+            if (e.message.includes('not in cache') || e.message.includes('ESM')) {
+              console.warn('Loading ESM test files manually due to Mocha compatibility issues')
+              // Load ESM files by importing them
+              await Promise.all(
+                jsFiles.map(async file => {
+                  try {
+                    // Convert file path to file:// URL for dynamic import
+                    const fileUrl = `file://${file}`
+                    await import(fileUrl)
+                  } catch (importErr) {
+                    // If dynamic import fails, the file may have syntax errors or other issues
+                    console.error(`Failed to load test file ${file}:`, importErr.message)
+                  }
+                }),
+              )
             } else {
               throw e
             }

lib/recorder.js

@@ -4,7 +4,6 @@ import promiseRetry from 'promise-retry'
 import chalk from 'chalk'
 import { printObjectProperties } from './utils.js'
 import output from './output.js'
-const { log } = output
 import { TimeoutError } from './timeout.js'
 const MAX_TASKS = 100
 
@@ -92,7 +91,7 @@ export default {
     queueId++
     sessionId = null
     asyncErr = null
-    log(`${currentQueue()} Starting recording promises`)
+    output.log(`${currentQueue()} Starting recording promises`)
     promise = Promise.resolve()
     oldPromises = []
     tasks = []
@@ -248,8 +247,9 @@ export default {
       .replace(/\n/g, ' ')
       ?.slice(0, 50)
     debug(chalk.gray(`${currentQueue()} Queued | catch with error handler ${fnDescription || ''}`))
+    if (!promise) promise = Promise.resolve()
     return (promise = promise.catch(err => {
-      log(`${currentQueue()}Error | ${err} ${fnDescription}...`)
+      output.log(`${currentQueue()}Error | ${err} ${fnDescription}...`)
       if (!(err instanceof Error)) {
         // strange things may happen
         err = new Error(`[Wrapped Error] ${printObjectProperties(err)}`) // we should be prepared for them
@@ -274,9 +274,10 @@ export default {
       ?.replace(/\s{2,}/g, ' ')
       .replace(/\n/g, ' ')
       ?.slice(0, 50)
+    if (!promise) promise = Promise.resolve()
     return (promise = promise.catch(err => {
       if (ignoredErrs.includes(err)) return // already caught
-      log(`${currentQueue()} Error (Non-Terminated) | ${err} | ${fnDescription || ''}...`)
+      output.log(`${currentQueue()} Error (Non-Terminated) | ${err} | ${fnDescription || ''}...`)
       if (!(err instanceof Error)) {
         // strange things may happen
         err = new Error(`[Wrapped Error] ${JSON.stringify(err)}`) // we should be prepared for them
@@ -340,7 +341,7 @@ export default {
    */
   stop() {
     debug(this.toString())
-    log(`${currentQueue()} Stopping recording promises`)
+    output.log(`${currentQueue()} Stopping recording promises`)
     running = false
   },
 

test/acceptance/react_test.js

@@ -1,8 +1,6 @@
-const { I } = inject()
-
 Feature('React Selectors')
 
-Scenario('props @Puppeteer @Playwright', () => {
+Scenario('props @Puppeteer @Playwright', ({ I }) => {
   I.amOnPage('https://codecept.io/test-react-calculator/')
   I.click('7')
   I.click({ react: 't', props: { name: '=' } })
@@ -13,15 +11,15 @@ Scenario('props @Puppeteer @Playwright', () => {
   I.seeElement({ react: 't', props: { value: '10' } })
 })
 
-Scenario('component name @Puppeteer @Playwright', () => {
+Scenario('component name @Puppeteer @Playwright', ({ I }) => {
   I.amOnPage('http://negomi.github.io/react-burger-menu/')
   I.click({ react: 'BurgerIcon' })
   I.waitForVisible('#slide', 10)
   I.click('Alerts')
   I.seeElement({ react: 'Demo' })
 })
 
-Scenario('using playwright locator @Playwright', () => {
+Scenario('using playwright locator @Playwright', ({ I }) => {
   I.amOnPage('https://codecept.io/test-react-calculator/')
   I.click('7')
   I.click({ pw: '_react=t[name = "="]' })