fixed webdriver

Author: DavertMik

.github/workflows/webdriver.yml

@@ -22,7 +22,7 @@ jobs:
         node-version: [20.x]
 
     steps:
-      - run: docker run -d -p 4444:4444 --shm-size=2g selenium/standalone-chrome:4.27
+      - run: docker run  --net=host -d --shm-size=2g selenium/standalone-chrome:4.27
       - uses: actions/checkout@v4
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v4

Dockerfile

@@ -1,6 +1,5 @@
 # Download Playwright and its dependencies
-FROM mcr.microsoft.com/playwright:v1.48.1-noble
-ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true
+FROM mcr.microsoft.com/playwright:v1.55.0-noble
 
 RUN apt-get update --allow-releaseinfo-change
 
@@ -19,29 +18,14 @@ RUN apt-get update && apt-get install -y gnupg wget && \
   apt-get install -y google-chrome-stable --no-install-recommends && \
   rm -rf /var/lib/apt/lists/*
 
-
-# Add pptr user.
-RUN groupadd -r pptruser && useradd -r -g pptruser -G audio,video pptruser \
-    && mkdir -p /home/pptruser/Downloads \
-    && chown -R pptruser:pptruser /home/pptruser \
-    && chown -R pptruser:pptruser /home/pptruser
-
-#RUN mkdir /home/codecept
-
 COPY . /codecept
-
-RUN chown -R pptruser:pptruser /codecept
-RUN runuser -l pptruser -c 'npm i --loglevel=warn --prefix /codecept'
+WORKDIR /codecept
+RUN npm install
 
 RUN ln -s /codecept/bin/codecept.js /usr/local/bin/codeceptjs
 RUN mkdir /tests
 WORKDIR /tests
-# Install puppeteer so it's available in the container.
-RUN npm i puppeteer@$(npm view puppeteer version) && npx puppeteer browsers install chrome
-RUN google-chrome --version
-
-# Install playwright browsers
-RUN npx playwright install
+RUN npm init -y && npm pkg set type=module
 
 # Allow to pass argument to codecept run via env variable
 ENV CODECEPT_ARGS=""
@@ -50,9 +34,7 @@ ENV NO_OF_WORKERS=""
 
 # Set HOST ENV variable for Selenium Server
 ENV HOST=selenium
-
-# Run user as non privileged.
-# USER pptruser
+ENV CODECEPT_DOCKER=1
 
 # Set the entrypoint
 ENTRYPOINT ["/codecept/docker/entrypoint"]

docker/entrypoint

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
 set -e
 
+# Set up module resolution - NODE_PATH is all we need
+export NODE_PATH=/codecept/lib:$NODE_PATH
+
 xvfb-run -a --server-args="-screen 0 1024x768x24" "$@"

docker/run.sh

@@ -6,6 +6,74 @@ source /codecept/docker/help.sh
 if [[ -d "/tests/" ]]; then
         echo "CodeceptJS directory has been found."
 
+	# Set up module resolution
+	export NODE_PATH=/codecept/lib:$NODE_PATH
+
+	# Ensure ESM package.json exists in test directory
+	ensure_esm_package() {
+		local dir="$1"
+		if [ ! -f "$dir/package.json" ]; then
+			echo "Creating package.json with ESM in $dir"
+			cat > "$dir/package.json" << EOF
+{
+  "type": "module"
+}
+EOF
+		elif ! grep -q '"type".*"module"' "$dir/package.json"; then
+			echo "Warning: $dir/package.json exists but may not have type: module"
+		fi
+	}
+
+	# Setup node_modules with ESM-compatible codeceptjs
+	setup_node_modules() {
+		local dir="$1"
+		local node_modules="$dir/node_modules"
+		local codecept_module="$node_modules/codeceptjs"
+
+		mkdir -p "$codecept_module"
+
+		cat > "$codecept_module/package.json" << 'EOF'
+{
+  "name": "codeceptjs",
+  "type": "module",
+  "exports": {
+    ".": "./index.js",
+    "./effects": "./effects.js"
+  },
+  "main": "./index.js"
+}
+EOF
+
+		ln -sf /codecept/lib/index.js "$codecept_module/index.js"
+		ln -sf /codecept/lib/effects.js "$codecept_module/effects.js"
+
+		for dep_dir in /codecept/node_modules/*; do
+			dep_name=$(basename "$dep_dir")
+			if [ "$dep_name" != "codeceptjs" ] && [ ! -e "$node_modules/$dep_name" ]; then
+				ln -sf "$dep_dir" "$node_modules/$dep_name" 2>/dev/null || true
+			fi
+		done
+	}
+
+	# Find codecept config in current directory
+	config_file=$(find . -maxdepth 2 -name "codecept.conf.*" -type f | head -1)
+
+	if [ -n "$config_file" ]; then
+		config_dir=$(dirname "$config_file")
+		ensure_esm_package "$config_dir"
+		setup_node_modules "$config_dir"
+	else
+		ensure_esm_package "$(pwd)"
+		setup_node_modules "$(pwd)"
+	fi
+
+	# Also setup node_modules in any subdirectories that might contain test files
+	for test_dir in acceptance test tests; do
+		if [ -d "$test_dir" ]; then
+			setup_node_modules "$test_dir"
+		fi
+	done
+
 	# Run the tests
 	cd /tests/ || exit
 	if [ "$RUN_MULTIPLE" = true ]; then

lib/command/interactive.js

@@ -21,6 +21,7 @@ export default async function (path, options) {
 
   try {
     await codecept.bootstrap()
+    await Container.started()
 
     if (options.verbose) output.level(3)
 
@@ -53,7 +54,6 @@ export default async function (path, options) {
       }
     }
     pause()
-    // recorder.catchWithoutStop((err) => console.log(err.stack));
     recorder.add(() => event.emit(event.test.after, {}))
     recorder.add(() => event.emit(event.suite.after, {}))
     recorder.add(() => event.emit(event.all.result, {}))

lib/helper/WebDriver.js

@@ -8,6 +8,7 @@ import { includes as stringIncludes } from '../assert/include.js'
 import { urlEquals, equals } from '../assert/equal.js'
 import store from '../store.js'
 import output from '../output.js'
+const { debug } = output
 import { empty } from '../assert/empty.js'
 import { truth } from '../assert/truth.js'
 import { xpathLocator, fileExists, decodeUrl, chunkArray, convertCssPropertiesToCamelCase, screenshotOutputFolder, getNormalizedKeyAttributeValue, modifierKeys } from '../utils.js'

test/acceptance/session_test.js

@@ -1,7 +1,8 @@
 import assert from 'assert'
 import { devices } from 'playwright'
-import { within } from '../../lib/effects.js'
-import event from '../../lib/event.js'
+
+import { within } from 'codeceptjs/effects';
+import { event } from 'codeceptjs'
 
 const output_dir = global.output_dir || './output'
 

test/docker-compose.yml

@@ -7,39 +7,36 @@ services:
       env_file: .env
       volumes:
         - ..:/codecept
-        - node_modules:/codecept/node_modules
     command: test/rest
     depends_on:
       - json_server
 
   test-acceptance.webdriverio:
     build: ..
     env_file: .env
+    working_dir: /tests
     environment:
-      - CODECEPT_ARGS=-c codecept.WebDriver.js --grep @WebDriverIO --debug
+      - CODECEPT_ARGS=-c acceptance/codecept.WebDriver.js --grep @WebDriverIO --debug
+      - NODE_PATH=/codecept/lib
     depends_on:
       - php
       - selenium.chrome
     volumes:
-      - ./acceptance:/tests
-      - ./data:/data
-      - ./support:/support
-      - node_modules:/node_modules
+      - .:/tests
 
   test-acceptance.puppeteer:
     build: ..
     env_file: .env
+    working_dir: /tests
     environment:
-      - CODECEPT_ARGS=-c codecept.Puppeteer.js --grep @Puppeteer
+      - CODECEPT_ARGS=-c acceptance/codecept.Puppeteer.js --grep @Puppeteer
       - PPT_VERSION=$PPT_VERSION
+      - NODE_PATH=/codecept/lib
     depends_on:
       - php
       - puppeteer-image
     volumes:
-      - ./acceptance:/tests
-      - ./data:/data
-      - ./support:/support
-      - node_modules:/node_modules
+      - .:/tests
 
   test-bdd.faker:
     build: ..
@@ -50,7 +47,6 @@ services:
       - ./bdd:/tests
       - ./data:/data
       - ./support:/support
-      - node_modules:/node_modules
 
   selenium.chrome:
     image: selenium/standalone-chrome:4.26
@@ -76,6 +72,3 @@ services:
 
   puppeteer-image:
     image: ghcr.io/puppeteer/puppeteer:22.4.1
-
-volumes:
-  node_modules: