fix: Major pool mode and worker infrastructure improvements

1. Worker Message Handler Race Condition:
   - Fixed critical race where workers started before message handlers attached
   - Moved worker creation and handler setup outside recorder.add()
   - Prevents workers from sending messages before handlers are ready

2. Pool Mode Test Request Loop:
   - Fixed race condition in REQUEST_TEST/TEST_ASSIGNED message handling
   - Set up message handler BEFORE sending request (was after)
   - Tests now properly wait for assignment before requesting next

3. Config File Loading:
   - Support .cjs/.mjs/.ts extensions when .js not found
   - Added .cjs to auto-discovery configFileNames list

4. Output Improvements:
   - Enhanced pool mode output to show test names (✔/✖)
   - Allow Feature() output in pool mode

Progress:
- Pool mode infrastructure now working correctly
- All 7 tests execute in pool mode (confirmed via logging)
- Worker-to-main communication fixed
- 187/214 runner tests passing (up from 170)

Known Issue:
- Pool mode test results not fully aggregating/displaying
- Only 2 of 7 executed tests appear in final output
- Individual test events may not be captured correctly in pool mode

Author: kobenguyent

lib/command/workers/runTests.js

@@ -26,14 +26,23 @@ const { options, tests, testRoot, workerIndex, poolMode } = workerData
 // In pool mode, only suppress output if debug is NOT enabled
 // In regular mode, hide result output but allow step output in verbose/debug
 if (poolMode && !options.debug) {
-  // In pool mode without debug, suppress only result summaries and failures, but allow Scenario Steps
+  // In pool mode without debug, allow test names and important output but suppress verbose details
   const originalWrite = process.stdout.write
   process.stdout.write = string => {
-    // Always allow Scenario Steps output (including the circle symbol)
-    if (string.includes('Scenario Steps:') || string.includes('◯ Scenario Steps:')) {
+    // Allow test names (✔ or ✖), Scenario Steps, failures, and important markers
+    if (
+      string.includes('✔') ||
+      string.includes('✖') ||
+      string.includes('Scenario Steps:') ||
+      string.includes('◯ Scenario Steps:') ||
+      string.includes('-- FAILURES:') ||
+      string.includes('AssertionError:') ||
+      string.includes('Feature(')
+    ) {
       return originalWrite.call(process.stdout, string)
     }
-    if (string.includes('  FAIL  |') || string.includes('  OK  |') || string.includes('-- FAILURES:') || string.includes('AssertionError:') || string.includes('◯ File:')) {
+    // Suppress result summaries to avoid duplicates
+    if (string.includes('  FAIL  |') || string.includes('  OK  |') || string.includes('◯ File:')) {
       return true
     }
     return originalWrite.call(process.stdout, string)
@@ -144,12 +153,13 @@ async function runPoolTests() {
 
   // Keep requesting tests until no more available
   while (true) {
-    // Request a test assignment
-    sendToParentThread({ type: 'REQUEST_TEST', workerIndex })
-
+    // Request a test assignment and wait for response
     const testResult = await new Promise((resolve, reject) => {
-      // Set up pool mode message handler
+      // Set up pool mode message handler FIRST before sending request
       const messageHandler = async eventData => {
+        // Remove handler immediately to prevent duplicate processing
+        parentPort?.off('message', messageHandler)
+        
         if (eventData.type === 'TEST_ASSIGNED') {
           const testUid = eventData.test
 
@@ -192,24 +202,26 @@ async function runPoolTests() {
               }
             }
 
-            // Signal test completed and request next
-            parentPort?.off('message', messageHandler)
+            // Signal test completed
             resolve('TEST_COMPLETED')
           } catch (err) {
-            parentPort?.off('message', messageHandler)
             reject(err)
           }
         } else if (eventData.type === 'NO_MORE_TESTS') {
           // No tests available, exit worker
-          parentPort?.off('message', messageHandler)
           resolve('NO_MORE_TESTS')
         } else {
-          // Handle other message types (support messages, etc.)
+          // Handle other message types (support messages, etc.) and re-add handler
           container.append({ support: eventData.data })
+          parentPort?.on('message', messageHandler)
         }
       }
 
+      // Set up handler BEFORE sending request to avoid race condition
       parentPort?.on('message', messageHandler)
+      
+      // Now send the request
+      sendToParentThread({ type: 'REQUEST_TEST', workerIndex })
     })
 
     // Exit if no more tests

lib/workers.js

@@ -485,12 +485,20 @@ class Workers extends EventEmitter {
     recorder.startUnlessRunning()
     event.dispatcher.emit(event.workers.before)
     process.env.RUNS_WITH_WORKERS = 'true'
-    recorder.add('starting workers', () => {
-      for (const worker of this.workers) {
-        const workerThread = createWorker(worker, this.isPoolMode)
-        this._listenWorkerEvents(workerThread)
-      }
+    
+    // Create workers and set up message handlers immediately (not in recorder queue)
+    // This prevents a race condition where workers start sending messages before handlers are attached
+    const workerThreads = []
+    for (const worker of this.workers) {
+      const workerThread = createWorker(worker, this.isPoolMode)
+      this._listenWorkerEvents(workerThread)
+      workerThreads.push(workerThread)
+    }
+    
+    recorder.add('workers started', () => {
+      // Workers are already running, this is just a placeholder step
     })
+    
     return new Promise(resolve => {
       this.on('end', resolve)
     })