Fix test hang issue when restart: false by properly mapping to context restart

Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>

Author: Copilot

lib/helper/extras/PlaywrightRestartOpts.js

@@ -14,9 +14,9 @@ export function setRestartStrategy(options) {
     return (restarts = restart)
   }
 
-  // When restart is false, don't restart anything
+  // When restart is false, map to 'context' restart (as per documentation)
   if (restart === false) {
-    restarts = null
+    restarts = 'context'
     return
   }
 

lib/listener/helpers.js

@@ -74,9 +74,10 @@ export default function () {
 
   event.dispatcher.on(event.all.result, () => {
     // Skip _finishTest for all helpers if any browser helper restarts to avoid double cleanup
+    // Note: restart: false is equivalent to restart: 'context' per documentation
     const hasBrowserRestart = Object.values(helpers).some(helper => 
-      (helper.config && (helper.config.restart === 'browser' || helper.config.restart === 'context' || helper.config.restart === true)) || 
-      (helper.options && (helper.options.restart === 'browser' || helper.options.restart === 'context' || helper.options.restart === true))
+      (helper.config && (helper.config.restart === 'browser' || helper.config.restart === 'context' || helper.config.restart === false || helper.config.restart === true)) || 
+      (helper.options && (helper.options.restart === 'browser' || helper.options.restart === 'context' || helper.options.restart === false || helper.options.restart === true))
     )
 
     Object.keys(helpers).forEach(key => {
@@ -89,9 +90,10 @@ export default function () {
 
   event.dispatcher.on(event.all.after, () => {
     // Skip _cleanup for all helpers if any browser helper restarts to avoid double cleanup
+    // Note: restart: false is equivalent to restart: 'context' per documentation
     const hasBrowserRestart = Object.values(helpers).some(helper => 
-      (helper.config && (helper.config.restart === 'browser' || helper.config.restart === 'context' || helper.config.restart === true)) || 
-      (helper.options && (helper.options.restart === 'browser' || helper.options.restart === 'context' || helper.options.restart === true))
+      (helper.config && (helper.config.restart === 'browser' || helper.config.restart === 'context' || helper.config.restart === false || helper.config.restart === true)) || 
+      (helper.options && (helper.options.restart === 'browser' || helper.options.restart === 'context' || helper.options.restart === false || helper.options.restart === true))
     )
 
     Object.keys(helpers).forEach(key => {

test/helper/PlaywrightRestartOpts_test.js

@@ -0,0 +1,50 @@
+import * as chai from 'chai'
+
+const assert = chai.assert
+const expect = chai.expect
+
+import { 
+  setRestartStrategy, 
+  restartsSession, 
+  restartsContext, 
+  restartsBrowser 
+} from '../../lib/helper/extras/PlaywrightRestartOpts.js'
+
+describe('PlaywrightRestartOpts', function () {
+  describe('setRestartStrategy', function () {
+    it('should set context restart when restart is false', function () {
+      setRestartStrategy({ restart: false })
+      assert.isFalse(restartsSession())
+      assert.isTrue(restartsContext())
+      assert.isFalse(restartsBrowser())
+    })
+
+    it('should set browser restart when restart is true', function () {
+      setRestartStrategy({ restart: true })
+      assert.isFalse(restartsSession())
+      assert.isFalse(restartsContext())
+      assert.isTrue(restartsBrowser())
+    })
+
+    it('should set context restart when restart is "context"', function () {
+      setRestartStrategy({ restart: 'context' })
+      assert.isFalse(restartsSession())
+      assert.isTrue(restartsContext())
+      assert.isFalse(restartsBrowser())
+    })
+
+    it('should set session restart when restart is "session"', function () {
+      setRestartStrategy({ restart: 'session' })
+      assert.isTrue(restartsSession())
+      assert.isFalse(restartsContext())
+      assert.isFalse(restartsBrowser())
+    })
+
+    it('should set browser restart when restart is "browser"', function () {
+      setRestartStrategy({ restart: 'browser' })
+      assert.isFalse(restartsSession())
+      assert.isFalse(restartsContext())
+      assert.isTrue(restartsBrowser())
+    })
+  })
+})