Remove magic number by adding a setting

Author: codeconscious

UniqueFileGenerator/FileHandler.cs

@@ -21,11 +21,11 @@ private IEnumerable<FileData> GetFileData()
 
         for (uint i = 0; i < Settings.FileCount; i++)
         {
-            var randomChars = stringFactory.CreateUniqueString(10);
-            var fileName = Settings.Prefix + randomChars;
+            var randomText = stringFactory.CreateUniqueString(length: Settings.RandomStringLength);
+            var fileName = Settings.Prefix + randomText;
 
             var contents = Settings.SizeInBytes.HasValue
-                ? stringFactory.CreateUniqueString(Settings.SizeInBytes.Value)
+                ? stringFactory.CreateUniqueString(length: Settings.SizeInBytes.Value)
                 : fileName;
 
             yield return new FileData(fileName, contents);

UniqueFileGenerator/Settings.cs

@@ -42,12 +42,15 @@ public sealed class Settings
     /// <summary>
     /// The amount of disk space that is necessary for the operation.
     /// </summary>
-    public long DiskSpaceNecessary => FileCount * (SizeInBytes ?? (Prefix.Length + 10));
+    public long DiskSpaceNecessary =>
+        FileCount * (SizeInBytes ?? (Prefix.Length + RandomStringLength));
 
     public bool IsHighFileCount => FileCount > 50_000;
     public bool IsLargeSize => SizeInBytes > 100_000_000;
     public bool IsLongDelay => FileCreationDelayMs > 60_000; // 1m
 
+    public const ushort RandomStringLength = 10; // This could be configurable too.
+
     public Settings(ParsedArguments parsedArgs)
     {
         FileCount = parsedArgs.FileCount;
@@ -135,4 +138,4 @@ private static bool IsLastCharAlphanumeric(string text) =>
 
     private static string EnforceStartingPeriod(string text) =>
         (text[0] == '.' ? string.Empty : ".") + text;
-}
+}