Skip to content

Commit 129ba9b

Browse files
committed
feat(leaderboard): replace index with rankText in rows
Updates the leaderboard entries table to use rankText instead of index for better clarity in displaying ranks. Changes include modifying the Row component's arguments and updating the entries-table templates to pass formatted rank values.
1 parent ee12684 commit 129ba9b

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

app/components/leaderboard-page/entries-table.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@
2323
</thead>
2424
<tbody>
2525
{{#each this.sortedTopEntries as |entry index|}}
26-
<LeaderboardPage::EntriesTable::Row @entry={{entry}} @index={{index}} />
26+
<LeaderboardPage::EntriesTable::Row @entry={{entry}} @rankText={{concat "#" (add index 1)}} />
2727
{{/each}}
2828

2929
{{#if this.shouldShowSurroundingEntries}}
3030
<LeaderboardPage::EntriesTable::FillerRow />
3131

3232
{{#each this.sortedSurroundingEntries as |entry index|}}
33-
<LeaderboardPage::EntriesTable::Row @entry={{entry}} @index={{(add 336501 index)}} />
33+
<LeaderboardPage::EntriesTable::Row @entry={{entry}} @rankText={{"#~5000"}} />
3434
{{/each}}
3535
{{/if}}
3636
</tbody>

app/components/leaderboard-page/entries-table/row.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
{{if this.isCurrentUser 'text-teal-600' 'text-gray-400'}}
55
text-right border border-gray-200 w-[8%]"
66
>
7-
#{{add @index 1}}
7+
{{@rankText}}
88
</td>
99
<td class="px-4 py-2 whitespace-nowrap border border-gray-200">
1010
<div class="flex items-center justify-between gap-x-6">

app/components/leaderboard-page/entries-table/row.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ interface Signature {
99

1010
Args: {
1111
entry: LeaderboardEntryModel;
12-
index: number;
12+
rankText: number;
1313
};
1414
}
1515

0 commit comments

Comments
 (0)