test(header): add linkHrefFor helper and wait for proper URL

Add a linkHrefFor method to the header page object to retrieve link hrefs 
by their text. Update the acceptance test for the leaderboard link to wait 
until the correct URL appears before clicking it. This ensures that the test 
does not proceed until the leaderboard link target is fully loaded, improving 
test stability.

refactor(preferred-language-leaderboard): format fetchForCurrentUser call

Reformat the fetchForCurrentUser invocation for better readability by 
passing the include option as an object on a single line. This change 
improves code consistency without altering functionality.

Author: rohitpaulk

app/services/preferred-language-leaderboard.ts

@@ -71,9 +71,9 @@ export default class PreferredLanguageLeaderboardService extends Service {
   async refresh(): Promise<void> {
     await this.authenticator.authenticate();
 
-    const userLeaderboardEntries = (await this.store
-      .createRecord('leaderboard-entry')
-      .fetchForCurrentUser({ include: 'leaderboard,leaderboard.language,user' })) as unknown as LeaderboardEntryModel[];
+    const userLeaderboardEntries = (await this.store.createRecord('leaderboard-entry').fetchForCurrentUser({
+      include: 'leaderboard,leaderboard.language,user',
+    })) as unknown as LeaderboardEntryModel[];
 
     this.preferredLanguageSlugs = userLeaderboardEntries
       .filter((entry) => entry.score > 0)

tests/acceptance/header-test.js

@@ -1,7 +1,7 @@
 import catalogPage from 'codecrafters-frontend/tests/pages/catalog-page';
 import testScenario from 'codecrafters-frontend/mirage/scenarios/test';
 import { assertTooltipContent } from 'ember-tooltips/test-support';
-import { currentURL } from '@ember/test-helpers';
+import { currentURL, waitUntil } from '@ember/test-helpers';
 import { module, test } from 'qunit';
 import { setupAnimationTest } from 'ember-animated/test-support';
 import { setupApplicationTest } from 'codecrafters-frontend/tests/helpers';
@@ -51,11 +51,15 @@ module('Acceptance | header-test', function (hooks) {
       leaderboard: python.leaderboard,
       user: user,
       score: 100,
+      relatedLanguageSlugs: [],
+      relatedCourseSlugs: [],
     });
 
     await catalogPage.visit();
     assert.true(catalogPage.header.hasLink('Leaderboard'), 'expect leaderboard link to be visible');
 
+    await waitUntil(() => catalogPage.header.linkHrefFor('Leaderboard') === '/leaderboards/python');
+
     await catalogPage.header.clickOnHeaderLink('Leaderboard');
     assert.strictEqual(currentURL(), '/leaderboards/python', 'expect to be redirected to python leaderboard page');
   });

tests/pages/components/header.ts

@@ -1,30 +1,34 @@
-import { clickOnText, collection } from 'ember-cli-page-object';
+import { attribute, clickOnText, collection } from 'ember-cli-page-object';
 import BillingStatusBadge from 'codecrafters-frontend/tests/pages/components/billing-status-badge';
 import FeedbackDropdown from 'codecrafters-frontend/tests/pages/components/feedback-dropdown';
 
 export default {
   campusBadge: BillingStatusBadge.campusBadge,
   clickOnHeaderLink: clickOnText('[data-test-header-link]'),
-
   discountTimerBadge: BillingStatusBadge.discountTimerBadge,
-
   feedbackDropdown: FeedbackDropdown,
 
   hasLink: function (linkText: string) {
     return !!this.links.toArray().find((link) => link.text === linkText);
   },
 
   freeWeeksLeftButton: BillingStatusBadge.freeWeeksLeftButton,
-  links: collection('[data-test-header-link]'),
-  memberBadge: BillingStatusBadge.memberBadge,
 
+  links: collection('[data-test-header-link]', {
+    href: attribute('href'),
+  }),
+
+  linkHrefFor: function (linkText: string) {
+    return this.links.toArray().find((link) => link.text === linkText)!.href;
+  },
+
+  memberBadge: BillingStatusBadge.memberBadge,
   scope: '[data-test-header]',
 
   signInButton: {
     scope: '[data-test-sign-in-with-github-button]',
   },
 
   upgradeButton: BillingStatusBadge.upgradeButton,
-
   vipBadge: BillingStatusBadge.vipBadge,
 };