Skip to content

Commit d5d92f3

Browse files
authored
Merge pull request #3103 from codecrafters-io/remove-deprecated-earn-badge-test
test: remove deprecated earn-badge test and related badge UI
2 parents ea20e02 + 4be5076 commit d5d92f3

File tree

7 files changed

+0
-157
lines changed

7 files changed

+0
-157
lines changed

app/components/course-page/course-stage-step/earned-badge-notice.hbs

Lines changed: 0 additions & 33 deletions
This file was deleted.

app/components/course-page/course-stage-step/earned-badge-notice.ts

Lines changed: 0 additions & 32 deletions
This file was deleted.

app/controllers/course/stage/instructions.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@ export default class CourseStageInstructionsController extends Controller {
2525
activeRepository: RepositoryModel;
2626
};
2727

28-
get badgeAwards() {
29-
return this.model.activeRepository.courseStageCompletions.filterBy('courseStage', this.model.courseStage).flatMap((courseStageCompletion) => {
30-
return courseStageCompletion.badgeAwards;
31-
});
32-
}
33-
3428
get currentCourse() {
3529
return this.model.courseStage.course;
3630
}

app/templates/course/stage/instructions.hbs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@
1919
/>
2020
{{/if}}
2121

22-
{{#if (gt this.badgeAwards.length 0)}}
23-
<CoursePage::CourseStageStep::EarnedBadgeNotice @badgeAwards={{this.badgeAwards}} class="mb-6" />
24-
{{/if}}
25-
2622
{{#if @model.courseStage.isFirst}}
2723
<CoursePage::CourseStageStep::FirstStageTutorialCard
2824
@repository={{@model.activeRepository}}

app/utils/repository-poller.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,6 @@ export default class RepositoryPoller extends Poller {
1212
'course',
1313
'course.extensions',
1414
'user',
15-
'user.badge-awards',
16-
'user.badge-awards.badge',
17-
'user.badge-awards.user',
18-
'user.badge-awards.course-stage-completion',
19-
'user.badge-awards.course-stage-completion.course-stage',
20-
'user.badge-awards.course-stage-completion.repository',
2115
'course-stage-completions',
2216
'course-stage-completions.course-stage',
2317
'course-stage-feedback-submissions',

tests/acceptance/course-page/earn-badge-test.js

Lines changed: 0 additions & 65 deletions
This file was deleted.

tests/pages/course-page.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -116,17 +116,6 @@ export default create({
116116
},
117117

118118
header: Header,
119-
120-
earnedBadgeNotice: {
121-
badgeEarnedModal: {
122-
badgeName: text('[data-test-badge-name]'),
123-
resetScope: true,
124-
scope: '[data-test-badge-earned-modal]',
125-
},
126-
127-
scope: '[data-test-earned-badge-notice]',
128-
},
129-
130119
feedbackPrompt: FeedbackPrompt,
131120
firstStageTutorialCard: FirstStageTutorialCard,
132121

0 commit comments

Comments
 (0)