Skip to content

Commit efb91eb

Browse files
committed
fix(danger-button): correct event handling comment for touchend trigger
1 parent 0b1fc0d commit efb91eb

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

app/components/danger-button-with-timed-confirmation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export default class DangerButtonWithTimedConfirmation extends Component<Signatu
2828

2929
@action
3030
startProgress(event: Event) {
31-
event.preventDefault(); // Prevent menu from popping up, which triggers touchup
31+
event.preventDefault(); // Prevent menu from popping up, which triggers touchend
3232
this.stopProgress();
3333

3434
this.shouldShowProgressBar = true;

tests/acceptance/concept-admin/delete-concept-test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ module('Acceptance | concept-admin | delete-concept-test', function (hooks) {
3737
await basicDetailsPage.deleteConceptModal.deleteConceptButton.mousedown();
3838
assert.ok(basicDetailsPage.deleteConceptModal.deleteConceptButton.progressIndicator.isVisible, 'progress indicator should be visible');
3939

40-
// assert progressIndicator.width is greater than 0
4140
await waitUntil(() => basicDetailsPage.deleteConceptModal.deleteConceptButton.progressIndicator.width > 0, { timeout: 10 });
4241
assert.ok(basicDetailsPage.deleteConceptModal.deleteConceptButton.progressIndicator.width > 0, 'progress indicator should have a width');
4342

@@ -76,7 +75,6 @@ module('Acceptance | concept-admin | delete-concept-test', function (hooks) {
7675
await basicDetailsPage.deleteConceptModal.deleteConceptButton.mousedown();
7776
assert.ok(basicDetailsPage.deleteConceptModal.deleteConceptButton.progressIndicator.isVisible, 'progress indicator should be visible');
7877

79-
// assert progressIndicator.width is greater than 0
8078
await waitUntil(() => basicDetailsPage.deleteConceptModal.deleteConceptButton.progressIndicator.width > 0, { timeout: 10 });
8179
assert.ok(basicDetailsPage.deleteConceptModal.deleteConceptButton.progressIndicator.width > 0, 'progress indicator should have a width');
8280

tests/acceptance/course-page/delete-repository-test.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ module('Acceptance | course-page | delete-repository-test', function (hooks) {
126126
);
127127
});
128128

129-
test('can delete repository after mouse down', async function (assert) {
129+
test('can delete repository via mouse down', async function (assert) {
130130
testScenario(this.server, ['dummy']);
131131
signInAsStaff(this.owner, this.server);
132132

@@ -153,7 +153,6 @@ module('Acceptance | course-page | delete-repository-test', function (hooks) {
153153
await coursePage.deleteRepositoryModal.deleteRepositoryButton.mousedown();
154154
assert.ok(coursePage.deleteRepositoryModal.deleteRepositoryButton.progressIndicator.isVisible, 'progress indicator should be visible');
155155

156-
// assert progressIndicator.width is greater than 0
157156
await waitUntil(() => coursePage.deleteRepositoryModal.deleteRepositoryButton.progressIndicator.width > 0, { timeout: 10 });
158157
assert.ok(coursePage.deleteRepositoryModal.deleteRepositoryButton.progressIndicator.width > 0, 'progress indicator should have a width');
159158

@@ -165,7 +164,7 @@ module('Acceptance | course-page | delete-repository-test', function (hooks) {
165164
assert.notOk(coursePage.repositoryDropdown.content.text.includes('Delete Repository'), 'delete repository action should not be available');
166165
});
167166

168-
test('can delete repository after touch start', async function (assert) {
167+
test('can delete repository via touch start', async function (assert) {
169168
testScenario(this.server, ['dummy']);
170169
signInAsStaff(this.owner, this.server);
171170

@@ -192,7 +191,6 @@ module('Acceptance | course-page | delete-repository-test', function (hooks) {
192191
await coursePage.deleteRepositoryModal.deleteRepositoryButton.touchstart();
193192
assert.ok(coursePage.deleteRepositoryModal.deleteRepositoryButton.progressIndicator.isVisible, 'progress indicator should be visible');
194193

195-
// assert progressIndicator.width is greater than 0
196194
await waitUntil(() => coursePage.deleteRepositoryModal.deleteRepositoryButton.progressIndicator.width > 0, { timeout: 10 });
197195
assert.ok(coursePage.deleteRepositoryModal.deleteRepositoryButton.progressIndicator.width > 0, 'progress indicator should have a width');
198196

0 commit comments

Comments
 (0)