Skip to content

Commit 828ea3c

Browse files
committed
init-release run manifests-local with env vars
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
1 parent 91da6fd commit 828ea3c

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.github/workflows/init-release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
echo "IMAGE_NAMESPACE=${IMAGE_NAMESPACE}"
6464
echo "IMAGE_REPOSITORY=${IMAGE_REPOSITORY}"
6565
make install-codegen-tools-local
66-
IMAGE_REGISTRY="$IMAGE_REGISTRY" && IMAGE_NAMESPACE="$IMAGE_NAMESPACE" && IMAGE_REPOSITORY="$IMAGE_REPOSITORY" make manifests-local VERSION=${{ inputs.TARGET_VERSION }}
66+
IMAGE_REGISTRY="$IMAGE_REGISTRY" IMAGE_NAMESPACE="$IMAGE_NAMESPACE" IMAGE_REPOSITORY="$IMAGE_REPOSITORY" make manifests-local VERSION=${{ inputs.TARGET_VERSION }}
6767
git diff
6868
6969
- name: Generate version compatibility table

docs/developer-guide/releasing.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ Example:
7171
./hack/trigger-release.sh v2.7.2 upstream
7272
```
7373

74+
The script will ask for confirmation, type `OFFICIAL` to proceed. If no confirmation is received within 30 seconds, the script will abort.
75+
7476
> [!TIP]
7577
> The tag must be in one of the following formats to trigger the GH workflow:<br>
7678
> * GA: `v<MAJOR>.<MINOR>.<PATCH>`<br>

0 commit comments

Comments
 (0)