Skip to content

Commit 1a285ce

Browse files
committed
switch over to our tracer init func
1 parent cf9887c commit 1a285ce

File tree

2 files changed

+30
-4
lines changed

2 files changed

+30
-4
lines changed

cmd/argocd-server/commands/argocd_server.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -270,10 +270,11 @@ func NewCommand() *cobra.Command {
270270
lns, err := argocd.Listen()
271271
errors.CheckError(err)
272272
if otlpAddress != "" {
273-
closer, err = traceutil.InitTracer(serverCtx, "argocd-server", otlpAddress, otlpInsecure, otlpHeaders, otlpAttrs)
274-
if err != nil {
275-
log.Fatalf("failed to initialize tracing: %v", err)
276-
}
273+
// closer, err = traceutil.InitTracer(serverCtx, "argocd-server", otlpAddress, otlpInsecure, otlpHeaders, otlpAttrs)
274+
// if err != nil {
275+
// log.Fatalf("failed to initialize tracing: %v", err)
276+
// }
277+
traceutil.InitGlobalTraceProvider(serverCtx)
277278
}
278279
argocd.Run(serverCtx, lns)
279280
if closer != nil {

util/trace/trace.go

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,3 +76,28 @@ func InitTracer(ctx context.Context, serviceName, otlpAddress string, otlpInsecu
7676
}
7777
}, nil
7878
}
79+
80+
func InitGlobalTraceProvider(ctx context.Context) (func(), error) {
81+
exporter, err := otlptracegrpc.New(ctx)
82+
if err != nil {
83+
return nil, err
84+
}
85+
86+
tp := sdktrace.NewTracerProvider(
87+
sdktrace.WithBatcher(exporter),
88+
sdktrace.WithResource(resource.NewWithAttributes(semconv.SchemaURL, semconv.ServiceNameKey.String("argocd-server"))),
89+
)
90+
91+
// set the global tracer provider
92+
otel.SetTracerProvider(tp)
93+
// set the global propagator to use TraceContext and Baggage
94+
otel.SetTextMapPropagator(propagation.NewCompositeTextMapPropagator(
95+
propagation.TraceContext{},
96+
propagation.Baggage{},
97+
))
98+
return func() {
99+
if err := exporter.Shutdown(ctx); err != nil {
100+
log.Errorf("failed to stop exporter: %v", err)
101+
}
102+
}, nil
103+
}

0 commit comments

Comments
 (0)