event-reporter: changes after pr review

Author: oleksandr-codefresh

event_reporter/reporter/application_event_reporter.go

@@ -224,15 +224,12 @@ func (s *applicationEventReporter) StreamApplicationEvents(
 
 func (s *applicationEventReporter) resolveApplicationVersions(ctx context.Context, a *appv1.Application, logCtx *log.Entry) *apiclient.ApplicationVersions {
 	syncRevision := utils.GetOperationStateRevision(a)
-	var applicationVersions *apiclient.ApplicationVersions
-	if syncRevision != nil {
-		syncManifests, _ := s.getDesiredManifests(ctx, a, syncRevision, logCtx)
-		applicationVersions = syncManifests.GetApplicationVersions()
-	} else {
-		applicationVersions = nil
+	if syncRevision == nil {
+		return &apiclient.ApplicationVersions{}
 	}
 
-	return applicationVersions
+	syncManifests, _ := s.getDesiredManifests(ctx, a, syncRevision, logCtx)
+	return syncManifests.GetApplicationVersions()
 }
 
 func (s *applicationEventReporter) getAppForResourceReporting(

event_reporter/reporter/event_payload.go

@@ -201,12 +201,8 @@ func buildEventObjectAsLiveAndCompiledManifestsEmpty(
 ) ([]byte, error) {
 	// no actual or desired state, don't send event
 	u := &unstructured.Unstructured{}
-	apiVersion := rr.rs.Version
-	if rr.rs.Group != "" {
-		apiVersion = rr.rs.Group + "/" + rr.rs.Version
-	}
 
-	u.SetAPIVersion(apiVersion)
+	u.SetAPIVersion(rr.GetApiVersion())
 	u.SetKind(rr.rs.Kind)
 	u.SetName(rr.rs.Name)
 	u.SetNamespace(rr.rs.Namespace)

event_reporter/reporter/types.go

@@ -31,3 +31,12 @@ type ArgoTrackingMetadata struct {
 	AppInstanceLabelKey *string
 	TrackingMethod      *appv1.TrackingMethod
 }
+
+func (rr *ReportedResource) GetApiVersion() string {
+	apiVersion := rr.rs.Version
+	if rr.rs.Group != "" {
+		apiVersion = rr.rs.Group + "/" + rr.rs.Version
+	}
+
+	return apiVersion
+}