apply code suggestions

Co-authored-by: neznaika0 <ozornick.ks@gmail.com>

Author: michalsn

system/Superglobals.php

@@ -55,12 +55,13 @@ public function __construct(
         private ?array $files = null,
         private ?array $request = null,
     ) {
-        $this->setServerArray($server ?? $_SERVER);
-        $this->setGetArray($get ?? $_GET);
-        $this->setPostArray($post ?? $_POST);
-        $this->setCookieArray($cookie ?? $_COOKIE);
-        $this->setFilesArray($files ?? $_FILES);
-        $this->setRequestArray($request ?? $_REQUEST);
+        $this
+            ->setServerArray($server ?? $_SERVER)
+            ->setGetArray($get ?? $_GET)
+            ->setPostArray($post ?? $_POST)
+            ->setCookieArray($cookie ?? $_COOKIE)
+            ->setFilesArray($files ?? $_FILES)
+            ->setRequestArray($request ?? $_REQUEST);
     }
 
     /**

tests/system/HTTP/MessageTest.php

@@ -266,7 +266,6 @@ public function testPopulateHeadersWithoutHTTP(): void
     {
         // fail path, if argument doesn't have the HTTP_*
         $superglobals = service('superglobals');
-        $original     = $superglobals->getServerArray();
         $superglobals->setServerArray([
             'USER_AGENT'     => 'Mozilla/5.0 (iPad; U; CPU OS 3_2_1 like Mac OS X; en-us) AppleWebKit/531.21.10 (KHTML, like Gecko) Mobile/7B405',
             'REQUEST_METHOD' => 'POST',
@@ -276,15 +275,12 @@ public function testPopulateHeadersWithoutHTTP(): void
 
         $this->assertNull($this->message->header('user-agent'));
         $this->assertNull($this->message->header('request-method'));
-
-        $superglobals->setServerArray($original); // restore so code coverage doesn't break
     }
 
     public function testPopulateHeadersKeyNotExists(): void
     {
         // Success path, if array key is not exists, assign empty string to it's value
         $superglobals = service('superglobals');
-        $original     = $superglobals->getServerArray();
         $superglobals->setServerArray([
             'CONTENT_TYPE'        => 'text/html; charset=utf-8',
             'HTTP_ACCEPT_CHARSET' => null,
@@ -293,15 +289,12 @@ public function testPopulateHeadersKeyNotExists(): void
         $this->message->populateHeaders();
 
         $this->assertSame('', $this->message->header('accept-charset')->getValue());
-
-        $superglobals->setServerArray($original); // restore so code coverage doesn't break
     }
 
     public function testPopulateHeaders(): void
     {
         // success path
         $superglobals = service('superglobals');
-        $original     = $superglobals->getServerArray();
         $superglobals->setServerArray([
             'CONTENT_TYPE'         => 'text/html; charset=utf-8',
             'HTTP_ACCEPT_LANGUAGE' => 'en-us,en;q=0.50',
@@ -311,8 +304,6 @@ public function testPopulateHeaders(): void
 
         $this->assertSame('text/html; charset=utf-8', $this->message->header('content-type')->getValue());
         $this->assertSame('en-us,en;q=0.50', $this->message->header('accept-language')->getValue());
-
-        $superglobals->setServerArray($original); // restore so code coverage doesn't break
     }
 
     public function testAddHeaderAddsFirstHeader(): void