remove !== "0" check

Author: samsonasik

system/CLI/CLI.php

@@ -262,7 +262,7 @@ public static function prompt(string $field, $options = null, $validation = null
             $default = $options[0];
         }
 
-        static::fwrite(STDOUT, $field . (trim($field) !== '' && trim($field) !== '0' ? ' ' : '') . $extraOutput . ': ');
+        static::fwrite(STDOUT, $field . (trim($field) !== '' ? ' ' : '') . $extraOutput . ': ');
 
         // Read the input from keyboard.
         $input = trim(static::input()) ?: $default;

system/Config/DotEnv.php

@@ -140,7 +140,7 @@ public function normaliseVariable(string $name, string $value = ''): array
      */
     protected function sanitizeValue(string $value): string
     {
-        if ($value === '' || $value === '0') {
+        if ($value === '') {
             return $value;
         }
 

system/HTTP/DownloadResponse.php

@@ -194,7 +194,7 @@ private function getContentDisposition(): string
 
         $result = sprintf('attachment; filename="%s"', $downloadFilename);
 
-        if ($utf8Filename !== '' && $utf8Filename !== '0') {
+        if ($utf8Filename !== '') {
             $result .= '; filename*=UTF-8\'\'' . rawurlencode($utf8Filename);
         }
 

system/Helpers/form_helper.php

@@ -29,7 +29,7 @@
     function form_open(string $action = '', $attributes = [], array $hidden = []): string
     {
         // If no action is provided then set to the current url
-        if ($action === '' || $action === '0') {
+        if ($action === '') {
             $action = current_url(true);
         } // If an action is not a full URL then turn it into one
         elseif (strpos($action, '://') === false) {

system/Helpers/html_helper.php

@@ -195,7 +195,7 @@ function doctype(string $type = 'html5'): string
     function script_tag($src = '', bool $indexPage = false): string
     {
         $cspNonce = csp_script_nonce();
-        $cspNonce = $cspNonce !== '' && $cspNonce !== '0' ? ' ' . $cspNonce : $cspNonce;
+        $cspNonce = $cspNonce !== '' ? ' ' . $cspNonce : $cspNonce;
         $script   = '<script' . $cspNonce . ' ';
         if (! is_array($src)) {
             $src = ['src' => $src];

system/Helpers/url_helper.php

@@ -318,7 +318,7 @@ function safe_mailto(string $email, string $title = '', $attributes = ''): strin
 
         // improve obfuscation by eliminating newlines & whitespace
         $cspNonce = csp_script_nonce();
-        $cspNonce = $cspNonce !== '' && $cspNonce !== '0' ? ' ' . $cspNonce : $cspNonce;
+        $cspNonce = $cspNonce !== '' ? ' ' . $cspNonce : $cspNonce;
         $output   = '<script' . $cspNonce . '>'
                 . 'var l=new Array();';
 

system/Router/RouteCollection.php

@@ -767,7 +767,7 @@ public function group(string $name, ...$params)
         // To register a route, we'll set a flag so that our router
         // will see the group name.
         // If the group name is empty, we go on using the previously built group name.
-        $this->group = $name !== '' && $name !== '0' ? trim($oldGroup . '/' . $name, '/') : $oldGroup;
+        $this->group = $name !== '' ? trim($oldGroup . '/' . $name, '/') : $oldGroup;
 
         $callback = array_pop($params);
 

system/Session/Handlers/FileHandler.php

@@ -73,7 +73,7 @@ public function __construct(SessionConfig $config, string $ipAddress)
         } else {
             $sessionPath = rtrim(ini_get('session.save_path'), '/\\');
 
-            if ($sessionPath === '' || $sessionPath === '0') {
+            if ($sessionPath === '') {
                 $sessionPath = WRITEPATH . 'session';
             }