Fix PHPStan iterable type errors in BaseModel, Model, and BaseHandler; clean baseline (#8732)

Author: chuchokun

system/BaseModel.php

@@ -436,7 +436,7 @@ abstract protected function doFindColumn(string $columnName);
      * @param int|null $limit  Limit
      * @param int      $offset Offset
      *
-     * @return array
+     * @return array<int,array<int|string,bool|float|int|object|string|null>|object>
      */
     abstract protected function doFindAll(?int $limit = null, int $offset = 0);
 
@@ -629,7 +629,7 @@ public function find($id = null)
      *
      * @param string $columnName Column Name
      *
-     * @return array|null The resulting row of data, or null if no data found.
+     * @return array<int,mixed>|null The resulting row of data, or null if no data found.
      *
      * @throws DataException
      */
@@ -650,7 +650,7 @@ public function findColumn(string $columnName)
      * @param int $limit  Limit
      * @param int $offset Offset
      *
-     * @return array
+     * @return array<mixed>
      */
     public function findAll(?int $limit = null, int $offset = 0)
     {
@@ -695,7 +695,7 @@ public function findAll(?int $limit = null, int $offset = 0)
     /**
      * Returns the first row of the result set.
      *
-     * @return array|object|null
+     * @return array<string,mixed>|object|null
      */
     public function first()
     {

utils/phpstan-baseline/missingType.iterableValue.neon

@@ -1,12 +1,12 @@
-# total 1215 errors
+# total 1209 errors
 
 parameters:
     ignoreErrors:
         -
             message: '#^Method CodeIgniter\\BaseModel\:\:__call\(\) has parameter \$params with no value type specified in iterable type array\.$#'
             count: 1
             path: ../../system/BaseModel.php
-            
+
         -
             message: '#^Method CodeIgniter\\BaseModel\:\:convertToReturnType\(\) return type has no value type specified in iterable type array\.$#'
             count: 1
@@ -27,11 +27,6 @@ parameters:
             count: 1
             path: ../../system/BaseModel.php
 
-        -
-            message: '#^Method CodeIgniter\\BaseModel\:\:doFindAll\(\) return type has no value type specified in iterable type array\.$#'
-            count: 1
-            path: ../../system/BaseModel.php
-
         -
             message: '#^Method CodeIgniter\\BaseModel\:\:doFindColumn\(\) return type has no value type specified in iterable type array\.$#'
             count: 1
@@ -72,21 +67,6 @@ parameters:
             count: 1
             path: ../../system/BaseModel.php
 
-        -
-            message: '#^Method CodeIgniter\\BaseModel\:\:findAll\(\) return type has no value type specified in iterable type array\.$#'
-            count: 1
-            path: ../../system/BaseModel.php
-
-        -
-            message: '#^Method CodeIgniter\\BaseModel\:\:findColumn\(\) return type has no value type specified in iterable type array\.$#'
-            count: 1
-            path: ../../system/BaseModel.php
-
-        -
-            message: '#^Method CodeIgniter\\BaseModel\:\:first\(\) return type has no value type specified in iterable type array\.$#'
-            count: 1
-            path: ../../system/BaseModel.php
-
         -
             message: '#^Method CodeIgniter\\BaseModel\:\:getIdValue\(\) return type has no value type specified in iterable type array\.$#'
             count: 1