refactor: remove deprecated static constructors of FrameworkException and child classes (#9977)

Author: paulbalandan

system/Exceptions/DownloadException.php

@@ -44,16 +44,6 @@ public static function forNotFoundDownloadSource()
         return new static(lang('HTTP.notFoundDownloadSource'));
     }
 
-    /**
-     * @deprecated Since v4.5.6
-     *
-     * @return static
-     */
-    public static function forCannotSetCache()
-    {
-        return new static(lang('HTTP.cannotSetCache'));
-    }
-
     /**
      * @return static
      */

system/Exceptions/FrameworkException.php

@@ -55,27 +55,6 @@ public static function forCopyError(string $path)
         return new static(lang('Core.copyError', [$path]));
     }
 
-    /**
-     * @return static
-     *
-     * @deprecated 4.5.0 No longer used.
-     */
-    public static function forMissingExtension(string $extension)
-    {
-        if (str_contains($extension, 'intl')) {
-            // @codeCoverageIgnoreStart
-            $message = sprintf(
-                'The framework needs the following extension(s) installed and loaded: %s.',
-                $extension,
-            );
-            // @codeCoverageIgnoreEnd
-        } else {
-            $message = lang('Core.missingExtension', [$extension]);
-        }
-
-        return new static($message);
-    }
-
     /**
      * @return static
      */

system/HTTP/Exceptions/HTTPException.php

@@ -217,20 +217,6 @@ public static function forMoveFailed(string $source, string $target, string $err
         return new static(lang('HTTP.moveFailed', [$source, $target, $error]));
     }
 
-    /**
-     * For Invalid SameSite attribute setting
-     *
-     * @return HTTPException
-     *
-     * @deprecated Use `CookieException::forInvalidSameSite()` instead.
-     *
-     * @codeCoverageIgnore
-     */
-    public static function forInvalidSameSiteSetting(string $samesite)
-    {
-        return new static(lang('Security.invalidSameSiteSetting', [$samesite]));
-    }
-
     /**
      * Thrown when the JSON format is not supported.
      * This is specifically for cases where data validation is expected to work with key-value structures.

system/Honeypot/Exceptions/HoneypotException.php

@@ -37,18 +37,6 @@ public static function forNoNameField()
         return new static(lang('Honeypot.noNameField'));
     }
 
-    /**
-     * Thrown when the hidden value of config is false.
-     *
-     * @return static
-     *
-     * @deprecated 4.6.4 Never used.
-     */
-    public static function forNoHiddenValue()
-    {
-        return new static(lang('Honeypot.noHiddenValue'));
-    }
-
     /**
      * Thrown when there are no data in the request of honeypot field.
      *

system/Images/Handlers/ImageMagickHandler.php

@@ -21,6 +21,7 @@
 use ImagickException;
 use ImagickPixel;
 use ImagickPixelException;
+use RuntimeException;
 
 /**
  * Image handler for Imagick extension.
@@ -46,7 +47,10 @@ public function __construct($config = null)
         parent::__construct($config);
 
         if (! extension_loaded('imagick')) {
-            throw ImageException::forMissingExtension('IMAGICK');  // @codeCoverageIgnore
+            throw new RuntimeException(sprintf(
+                'The "%s" handler requires the "imagick" PHP extension.',
+                static::class,
+            ));
         }
     }
 

system/Language/en/Core.php

@@ -18,6 +18,5 @@
     'invalidFile'                  => 'Invalid file: "{0}"',
     'invalidDirectory'             => 'Directory does not exist: "{0}"',
     'invalidPhpVersion'            => 'Your PHP version must be {0} or higher to run CodeIgniter. Current version: {1}',
-    'missingExtension'             => 'The framework needs the following extension(s) installed and loaded: "{0}".',
     'noHandlers'                   => '"{0}" must provide at least one Handler.',
 ];

system/Language/en/HTTP.php

@@ -37,7 +37,6 @@
     'cannotSetBinary'        => 'When setting filepath cannot set binary.',
     'cannotSetFilepath'      => 'When setting binary cannot set filepath: "{0}"',
     'notFoundDownloadSource' => 'Not found download body source.',
-    'cannotSetCache'         => 'It does not support caching for downloading.',
     'cannotSetStatusCode'    => 'It does not support change status code for downloading. code: {0}, reason: {1}',
 
     // Response
@@ -76,8 +75,4 @@
     'uploadErrNoTmpDir'  => 'File could not be uploaded: missing temporary directory.',
     'uploadErrExtension' => 'File upload was stopped by a PHP extension.',
     'uploadErrUnknown'   => 'The file "%s" was not uploaded due to an unknown error.',
-
-    // SameSite setting
-    // @deprecated
-    'invalidSameSiteSetting' => 'The SameSite setting must be None, Lax, Strict, or a blank string. Given: {0}',
 ];

system/Language/en/Security.php

@@ -15,7 +15,4 @@
 return [
     'disallowedAction' => 'The action you requested is not allowed.',
     'insecureCookie'   => 'Attempted to send a secure cookie over a non-secure connection.',
-
-    // @deprecated
-    'invalidSameSite' => 'The SameSite value must be None, Lax, Strict, or a blank string. Given: "{0}"',
 ];

system/Language/en/Session.php

@@ -18,7 +18,4 @@
     'writeProtectedSavePath' => 'Session: Configured save path "{0}" is not writable by the PHP process.',
     'emptySavePath'          => 'Session: No save path configured.',
     'invalidSavePathFormat'  => 'Session: Invalid Redis save path format: "{0}"',
-
-    // @deprecated
-    'invalidSameSiteSetting' => 'Session: The SameSite setting must be None, Lax, Strict, or a blank string. Given: "{0}"',
 ];

system/Security/Exceptions/SecurityException.php

@@ -69,16 +69,4 @@ public static function forInvalidControlChars(string $source, string $string)
             400,
         );
     }
-
-    /**
-     * @deprecated Use `CookieException::forInvalidSameSite()` instead.
-     *
-     * @codeCoverageIgnore
-     *
-     * @return static
-     */
-    public static function forInvalidSameSite(string $samesite)
-    {
-        return new static(lang('Security.invalidSameSite', [$samesite]));
-    }
 }