tests: persistent connection session redis

fix: test persistent parameter false

Author: ddevsr

system/Session/Handlers/RedisHandler.php

@@ -142,7 +142,7 @@ protected function setSavePath(): void
             }
         }
 
-        $persistent = $query['persistent'] ?? null;
+        $persistent = isset($query['persistent']) ? (bool) $query['persistent'] : null;
         $password   = $query['auth'] ?? null;
         $database   = isset($query['database']) ? (int) $query['database'] : 0;
         $timeout    = isset($query['timeout']) ? (float) $query['timeout'] : 0.0;

tests/system/Session/Handlers/Database/RedisHandlerTest.php

@@ -163,81 +163,111 @@ public static function provideSetSavePath(): iterable
             'w/o protocol' => [
                 '127.0.0.1:6379',
                 [
-                    'host'     => 'tcp://127.0.0.1',
-                    'port'     => 6379,
-                    'password' => null,
-                    'database' => 0,
-                    'timeout'  => 0.0,
+                    'host'       => 'tcp://127.0.0.1',
+                    'port'       => 6379,
+                    'password'   => null,
+                    'database'   => 0,
+                    'timeout'    => 0.0,
+                    'persistent' => null,
                 ],
             ],
             'tls auth' => [
                 'tls://127.0.0.1:6379?auth=password',
                 [
-                    'host'     => 'tls://127.0.0.1',
-                    'port'     => 6379,
-                    'password' => 'password',
-                    'database' => 0,
-                    'timeout'  => 0.0,
+                    'host'       => 'tls://127.0.0.1',
+                    'port'       => 6379,
+                    'password'   => 'password',
+                    'database'   => 0,
+                    'timeout'    => 0.0,
+                    'persistent' => null,
                 ],
             ],
             'tcp auth' => [
                 'tcp://127.0.0.1:6379?auth=password',
                 [
-                    'host'     => 'tcp://127.0.0.1',
-                    'port'     => 6379,
-                    'password' => 'password',
-                    'database' => 0,
-                    'timeout'  => 0.0,
+                    'host'       => 'tcp://127.0.0.1',
+                    'port'       => 6379,
+                    'password'   => 'password',
+                    'database'   => 0,
+                    'timeout'    => 0.0,
+                    'persistent' => null,
                 ],
             ],
             'timeout float' => [
                 'tcp://127.0.0.1:6379?timeout=2.5',
                 [
-                    'host'     => 'tcp://127.0.0.1',
-                    'port'     => 6379,
-                    'password' => null,
-                    'database' => 0,
-                    'timeout'  => 2.5,
+                    'host'       => 'tcp://127.0.0.1',
+                    'port'       => 6379,
+                    'password'   => null,
+                    'database'   => 0,
+                    'timeout'    => 2.5,
+                    'persistent' => null,
                 ],
             ],
             'timeout int' => [
                 'tcp://127.0.0.1:6379?timeout=10',
                 [
-                    'host'     => 'tcp://127.0.0.1',
-                    'port'     => 6379,
-                    'password' => null,
-                    'database' => 0,
-                    'timeout'  => 10.0,
+                    'host'       => 'tcp://127.0.0.1',
+                    'port'       => 6379,
+                    'password'   => null,
+                    'database'   => 0,
+                    'timeout'    => 10.0,
+                    'persistent' => null,
                 ],
             ],
             'auth acl' => [
                 'tcp://localhost:6379?auth[user]=redis-admin&auth[pass]=admin-password',
                 [
-                    'host'     => 'tcp://localhost',
-                    'port'     => 6379,
-                    'password' => ['user' => 'redis-admin', 'pass' => 'admin-password'],
-                    'database' => 0,
-                    'timeout'  => 0.0,
+                    'host'       => 'tcp://localhost',
+                    'port'       => 6379,
+                    'password'   => ['user' => 'redis-admin', 'pass' => 'admin-password'],
+                    'database'   => 0,
+                    'timeout'    => 0.0,
+                    'persistent' => null,
                 ],
             ],
             'unix domain socket' => [
                 'unix:///tmp/redis.sock',
                 [
-                    'host'     => '/tmp/redis.sock',
-                    'port'     => 0,
-                    'password' => null,
-                    'database' => 0,
-                    'timeout'  => 0.0,
+                    'host'       => '/tmp/redis.sock',
+                    'port'       => 0,
+                    'password'   => null,
+                    'database'   => 0,
+                    'timeout'    => 0.0,
+                    'persistent' => null,
                 ],
             ],
             'unix domain socket w/o protocol' => [
                 '/tmp/redis.sock',
                 [
-                    'host'     => '/tmp/redis.sock',
-                    'port'     => 0,
-                    'password' => null,
-                    'database' => 0,
-                    'timeout'  => 0.0,
+                    'host'       => '/tmp/redis.sock',
+                    'port'       => 0,
+                    'password'   => null,
+                    'database'   => 0,
+                    'timeout'    => 0.0,
+                    'persistent' => null,
+                ],
+            ],
+            'persistent connection' => [
+                'tcp://127.0.0.1:6379?timeout=10&persistent=1',
+                [
+                    'host'       => 'tcp://127.0.0.1',
+                    'port'       => 6379,
+                    'password'   => null,
+                    'database'   => 0,
+                    'timeout'    => 10.0,
+                    'persistent' => true,
+                ],
+            ],
+            'no persistent connection with have parameter' => [
+                'tcp://127.0.0.1:6379?timeout=10&persistent=0',
+                [
+                    'host'       => 'tcp://127.0.0.1',
+                    'port'       => 6379,
+                    'password'   => null,
+                    'database'   => 0,
+                    'timeout'    => 10.0,
+                    'persistent' => false,
                 ],
             ],
         ];