fix: stabilize bun tests for timers and module mocks

Change-Id: Ib691f6831627e0e03ecfb26339a6bd9b4a4c310c
Signed-off-by: Thomas Kosiewski <tk@coder.com>

Author: ThomasK33

src/browser/contexts/API.test.tsx

@@ -66,6 +66,7 @@ void mock.module("@orpc/client/message-port", () => ({
 }));
 
 void mock.module("@/browser/components/AuthTokenModal", () => ({
+  AuthTokenModal: () => null,
   getStoredAuthToken: () => null,
   // eslint-disable-next-line @typescript-eslint/no-empty-function
   clearStoredAuthToken: () => {},

src/browser/hooks/useVoiceInput.ts

@@ -57,7 +57,8 @@ export interface UseVoiceInputResult {
  */
 function hasTouchDictation(): boolean {
   if (typeof window === "undefined") return false;
-  const hasTouch = "ontouchstart" in window || navigator.maxTouchPoints > 0;
+  const hasTouch =
+    "ontouchstart" in window || (typeof navigator !== "undefined" && navigator.maxTouchPoints > 0);
   // Touch-only check: most touch devices have native dictation.
   // We don't check screen size because iPads are large but still have dictation.
   return hasTouch;
@@ -66,7 +67,9 @@ function hasTouchDictation(): boolean {
 const HAS_TOUCH_DICTATION = hasTouchDictation();
 const HAS_MEDIA_RECORDER = typeof window !== "undefined" && typeof MediaRecorder !== "undefined";
 const HAS_GET_USER_MEDIA =
-  typeof window !== "undefined" && typeof navigator.mediaDevices?.getUserMedia === "function";
+  typeof window !== "undefined" &&
+  typeof navigator !== "undefined" &&
+  typeof navigator.mediaDevices?.getUserMedia === "function";
 
 // =============================================================================
 // Global Key State Tracking
@@ -79,7 +82,7 @@ const HAS_GET_USER_MEDIA =
  */
 let isSpaceCurrentlyHeld = false;
 
-if (typeof window !== "undefined") {
+if (typeof window !== "undefined" && typeof window.addEventListener === "function") {
   window.addEventListener(
     "keydown",
     (e) => {

src/browser/utils/RefreshController.test.ts

@@ -1,35 +1,31 @@
-import { describe, it, expect, beforeEach, afterEach, jest } from "@jest/globals";
-import { RefreshController } from "./RefreshController";
+import { describe, it, expect, mock } from "bun:test";
 
-describe("RefreshController", () => {
-  beforeEach(() => {
-    jest.useFakeTimers();
-  });
+import { RefreshController } from "./RefreshController";
 
-  afterEach(() => {
-    jest.useRealTimers();
-  });
+const sleep = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));
 
-  it("debounces multiple schedule() calls", () => {
-    const onRefresh = jest.fn<() => void>();
-    const controller = new RefreshController({ onRefresh, debounceMs: 100 });
+describe("RefreshController", () => {
+  it("debounces multiple schedule() calls", async () => {
+    const onRefresh = mock<() => void>(() => undefined);
+    const controller = new RefreshController({ onRefresh, debounceMs: 50 });
 
     controller.schedule();
     controller.schedule();
     controller.schedule();
 
     expect(onRefresh).not.toHaveBeenCalled();
 
-    jest.advanceTimersByTime(100);
+    // Use real timers because bun's jest compatibility doesn't expose timer controls.
+    await sleep(120);
 
     expect(onRefresh).toHaveBeenCalledTimes(1);
 
     controller.dispose();
   });
 
-  it("requestImmediate() bypasses debounce", () => {
-    const onRefresh = jest.fn<() => void>();
-    const controller = new RefreshController({ onRefresh, debounceMs: 100 });
+  it("requestImmediate() bypasses debounce", async () => {
+    const onRefresh = mock<() => void>(() => undefined);
+    const controller = new RefreshController({ onRefresh, debounceMs: 50 });
 
     controller.schedule();
     expect(onRefresh).not.toHaveBeenCalled();
@@ -38,7 +34,7 @@ describe("RefreshController", () => {
     expect(onRefresh).toHaveBeenCalledTimes(1);
 
     // Original debounce timer should be cleared
-    jest.advanceTimersByTime(100);
+    await sleep(120);
     expect(onRefresh).toHaveBeenCalledTimes(1);
 
     controller.dispose();
@@ -47,15 +43,15 @@ describe("RefreshController", () => {
   it("guards against concurrent sync refreshes (in-flight queuing)", () => {
     // Track if refresh is currently in-flight
     let inFlight = false;
-    const onRefresh = jest.fn(() => {
+    const onRefresh = mock(() => {
       // Simulate sync operation that takes time
       expect(inFlight).toBe(false); // Should never be called while already in-flight
       inFlight = true;
       // Immediately complete (sync)
       inFlight = false;
     });
 
-    const controller = new RefreshController({ onRefresh, debounceMs: 100 });
+    const controller = new RefreshController({ onRefresh, debounceMs: 50 });
 
     // Multiple immediate requests should only call once (queued ones execute after)
     controller.requestImmediate();
@@ -64,14 +60,14 @@ describe("RefreshController", () => {
     controller.dispose();
   });
 
-  it("isRefreshing reflects in-flight state", () => {
+  it("isRefreshing reflects in-flight state", async () => {
     let resolveRefresh: () => void;
     const refreshPromise = new Promise<void>((resolve) => {
       resolveRefresh = resolve;
     });
 
-    const onRefresh = jest.fn(() => refreshPromise);
-    const controller = new RefreshController({ onRefresh, debounceMs: 100 });
+    const onRefresh = mock(() => refreshPromise);
+    const controller = new RefreshController({ onRefresh, debounceMs: 50 });
 
     expect(controller.isRefreshing).toBe(false);
 
@@ -80,31 +76,34 @@ describe("RefreshController", () => {
 
     // Complete the promise
     resolveRefresh!();
+    await Promise.resolve();
+
+    expect(controller.isRefreshing).toBe(false);
 
     controller.dispose();
   });
 
-  it("dispose() cleans up debounce timer", () => {
-    const onRefresh = jest.fn<() => void>();
-    const controller = new RefreshController({ onRefresh, debounceMs: 100 });
+  it("dispose() cleans up debounce timer", async () => {
+    const onRefresh = mock<() => void>(() => undefined);
+    const controller = new RefreshController({ onRefresh, debounceMs: 50 });
 
     controller.schedule();
     controller.dispose();
 
-    jest.advanceTimersByTime(100);
+    await sleep(120);
 
     expect(onRefresh).not.toHaveBeenCalled();
   });
 
-  it("does not refresh after dispose", () => {
-    const onRefresh = jest.fn<() => void>();
-    const controller = new RefreshController({ onRefresh, debounceMs: 100 });
+  it("does not refresh after dispose", async () => {
+    const onRefresh = mock<() => void>(() => undefined);
+    const controller = new RefreshController({ onRefresh, debounceMs: 50 });
 
     controller.dispose();
     controller.schedule();
     controller.requestImmediate();
 
-    jest.advanceTimersByTime(100);
+    await sleep(120);
 
     expect(onRefresh).not.toHaveBeenCalled();
   });

src/node/services/tools/task.test.ts

@@ -75,6 +75,7 @@ describe("task tool", () => {
       taskId: "child-task",
       reportMarkdown: "Hello from child",
       title: "Result",
+      agentId: "explore",
       agentType: "explore",
     });
   });