Clean up notification code: fix desktop notifications and remove unused IPC

- Move desktop notification logic into NotificationService (was broken)
- Desktop notifications now show properly via server-side trigger
- Remove unused NOTIFICATION_SEND IPC channel and handler
- Remove send() method from notification API (not needed)
- Use dynamic import instead of require for electron module
- Update all comments to reflect server-side architecture

Author: kylecarbs

src/App.stories.tsx

@@ -89,7 +89,6 @@ function setupMockAPI(options: {
       subscribePush: () => Promise.resolve(undefined),
       unsubscribePush: () => Promise.resolve(undefined),
       getVapidKey: () => Promise.resolve(null),
-      send: () => Promise.resolve(undefined),
     },
     ...options.apiOverrides,
   };

src/browser/api.ts

@@ -276,8 +276,6 @@ const webApi: IPCApi = {
     unsubscribePush: (workspaceId, endpoint) =>
       invokeIPC(IPC_CHANNELS.NOTIFICATION_UNSUBSCRIBE_PUSH, workspaceId, endpoint),
     getVapidKey: () => invokeIPC(IPC_CHANNELS.NOTIFICATION_GET_VAPID_KEY),
-    send: (workspaceId, workspaceName) =>
-      invokeIPC(IPC_CHANNELS.NOTIFICATION_SEND, workspaceId, workspaceName),
   },
 };
 

src/constants/ipc-constants.ts

@@ -52,7 +52,6 @@ export const IPC_CHANNELS = {
   NOTIFICATION_SUBSCRIBE_PUSH: "notification:subscribePush",
   NOTIFICATION_UNSUBSCRIBE_PUSH: "notification:unsubscribePush",
   NOTIFICATION_GET_VAPID_KEY: "notification:getVapidKey",
-  NOTIFICATION_SEND: "notification:send",
 
   // Dynamic channel prefixes
   WORKSPACE_CHAT_PREFIX: "workspace:chat:",

src/preload.ts

@@ -148,8 +148,6 @@ const api: IPCApi = {
     unsubscribePush: (workspaceId: string, endpoint: string) =>
       ipcRenderer.invoke(IPC_CHANNELS.NOTIFICATION_UNSUBSCRIBE_PUSH, workspaceId, endpoint),
     getVapidKey: () => ipcRenderer.invoke(IPC_CHANNELS.NOTIFICATION_GET_VAPID_KEY),
-    send: (workspaceId: string, workspaceName: string) =>
-      ipcRenderer.invoke(IPC_CHANNELS.NOTIFICATION_SEND, workspaceId, workspaceName),
   },
 };
 

src/services/NotificationService.ts

@@ -103,13 +103,25 @@ export class NotificationService {
 
   /**
    * Send a completion notification
-   * Desktop: Shows Electron notification (handled by caller)
+   * Desktop: Shows Electron notification directly (no push needed)
    * Web/Mobile: Sends push notification to all subscribed clients
    */
   async sendCompletionNotification(workspaceId: string, workspaceName: string): Promise<void> {
     if (this.isDesktop) {
-      // Desktop notifications are handled by the caller (main-desktop.ts)
-      // This method is only called for web/mobile push notifications
+      // Desktop: Show native Electron notification
+      try {
+        // Dynamic import required: can't statically import electron in server mode
+        // eslint-disable-next-line no-restricted-syntax -- Dynamic import necessary for server compatibility
+        const electron = await import("electron");
+        const notification = new electron.Notification({
+          title: "Completion",
+          body: `${workspaceName} has finished`,
+        });
+        notification.show();
+        log.debug(`Showed desktop notification for workspace ${workspaceId}`);
+      } catch (error) {
+        log.error("Failed to show desktop notification:", error);
+      }
       return;
     }
 

src/services/ipcMain.ts

@@ -1210,37 +1210,9 @@ export class IpcMain {
       }
     );
 
-    // Send notification (for desktop or push)
-    ipcMain.handle(
-      IPC_CHANNELS.NOTIFICATION_SEND,
-      async (_event, workspaceId: string, workspaceName: string) => {
-        try {
-          if (this.isDesktop) {
-            // Dynamic import required: can't statically import electron in server mode
-            // eslint-disable-next-line no-restricted-syntax -- Dynamic import necessary for server compatibility
-            const { Notification } = await import("electron");
-            const notification = new Notification({
-              title: "Completion",
-              body: `${workspaceName} has finished`,
-            });
-            notification.on("click", () => {
-              if (this.mainWindow) {
-                if (this.mainWindow.isMinimized()) {
-                  this.mainWindow.restore();
-                }
-                this.mainWindow.focus();
-              }
-            });
-            notification.show();
-          } else {
-            // For web/mobile, send push notifications
-            await this.notificationService.sendCompletionNotification(workspaceId, workspaceName);
-          }
-        } catch (error) {
-          log.error("Failed to send notification:", error);
-        }
-      }
-    );
+    // Note: NOTIFICATION_SEND handler intentionally omitted
+    // Notifications are now triggered server-side in AgentSession on stream-end
+    // This ensures push notifications work even when the app is closed (PWA/mobile)
   }
 
   private registerProjectHandlers(ipcMain: ElectronIpcMain): void {

src/types/ipc.ts

@@ -298,7 +298,7 @@ export interface IPCApi {
     subscribePush(workspaceId: string, subscription: unknown): Promise<void>;
     unsubscribePush(workspaceId: string, endpoint: string): Promise<void>;
     getVapidKey(): Promise<string | null>;
-    send(workspaceId: string, workspaceName: string): Promise<void>;
+    // Note: send() method removed - notifications triggered server-side in AgentSession
   };
 }