Skip to content

Commit 2f26bed

Browse files
committed
🤖 ci: parallelize macOS PR builds by skipping signing setup
PR builds were running x64 and arm64 sequentially (~180s) because: 1. CSC_LINK was set by the signing setup script 2. Makefile sees CSC_LINK and forces sequential builds to avoid keychain conflicts 3. But electron-builder skips signing for PRs anyway! Fix: Skip signing setup for PRs entirely. This allows the Makefile to run both architectures in parallel, saving ~90 seconds per PR build. Evidence from run #19845830777: - 03:24:40 "🔐 Code signing enabled - building sequentially..." - 03:26:12 "Current build is a part of pull request, code signing will be skipped" - x64: 03:26:12 → 03:27:43 (~91s) - arm64: 03:27:59 → 03:29:29 (~90s) - started AFTER x64 finished With this change, both will build simultaneously. _Generated with mux_
1 parent 1e3dce5 commit 2f26bed

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

.github/workflows/build.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,11 @@ jobs:
1818

1919
- uses: ./.github/actions/setup-mux
2020

21+
# Skip signing setup for PRs - electron-builder skips signing anyway,
22+
# but setting CSC_LINK forces our Makefile to build sequentially.
23+
# Without CSC_LINK, x64 and arm64 build in parallel (~90s savings).
2124
- name: Setup code signing
25+
if: github.event_name != 'pull_request'
2226
run: ./scripts/setup-macos-signing.sh
2327
env:
2428
MACOS_CERTIFICATE: ${{ secrets.MACOS_CERTIFICATE }}
@@ -28,6 +32,7 @@ jobs:
2832
AC_APIKEY_ISSUER_ID: ${{ secrets.AC_APIKEY_ISSUER_ID }}
2933

3034
- name: Verify signing setup
35+
if: github.event_name != 'pull_request'
3136
run: |
3237
if [ -n "${CSC_LINK:-}" ]; then
3338
echo "✅ Code signing enabled"
@@ -39,8 +44,6 @@ jobs:
3944
4045
- name: Package for macOS
4146
run: make dist-mac
42-
env:
43-
CSC_FOR_PULL_REQUEST: ${{ github.event.pull_request.number == 234 }}
4447

4548
- name: Upload macOS DMG (x64)
4649
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)