ci: add smoke test to catch MockBrowserWindow regressions

Enhanced smoke-test.sh to exercise IPC and WebSocket flows that use
MockBrowserWindow methods like isDestroyed(). Added smoke-test job
to CI that runs on merge queue.

The test:
- Creates a project via IPC
- Creates a workspace via IPC (triggers isDestroyed checks)
- Subscribes to workspace chat via WebSocket

This would have caught the regression in commit 3ca9c7e where
isDestroyed() was added to ipcMain.ts but not to MockBrowserWindow
in src/cli/server.ts.

_Generated with mux_

Author: ibetitsmike

.github/workflows/ci.yml

@@ -238,6 +238,44 @@ jobs:
         if: always()
         run: docker rm -f mux-test || true
 
+  npm-smoke-test:
+    name: NPM Smoke Test
+    runs-on: ${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-16' || 'ubuntu-latest' }}
+    # Only run on merge queue - tests IPC/WebSocket flows that catch MockBrowserWindow bugs
+    if: github.event_name == 'merge_group'
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0 # Required for git describe to find tags
+
+      - uses: ./.github/actions/setup-mux
+
+      - name: Build application
+        run: make build
+
+      - name: Pack npm package
+        run: npm pack
+
+      - name: Run smoke test
+        env:
+          SERVER_PORT: 3001
+          SERVER_HOST: localhost
+          STARTUP_TIMEOUT: 30
+        run: |
+          # Find the actual tarball name (version may vary)
+          TARBALL=$(ls mux-*.tgz | head -1)
+          PACKAGE_TARBALL="$TARBALL" ./scripts/smoke-test.sh
+
+      - name: Upload server logs on failure
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: npm-smoke-test-logs
+          path: /tmp/tmp.*/server.log
+          if-no-files-found: warn
+          retention-days: 7
+
   check-codex-comments:
     name: Check Codex Comments
     runs-on: ${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-16' || 'ubuntu-latest' }}

scripts/smoke-test.sh

@@ -172,5 +172,120 @@ fi
 
 log_info "✅ Root endpoint is accessible"
 
+# Test IPC functionality - this exercises MockBrowserWindow methods like isDestroyed()
+log_info "Testing IPC project creation..."
+
+# Create a temporary git repo for the test project
+PROJECT_DIR=$(mktemp -d)
+git init -b main "$PROJECT_DIR" >/dev/null 2>&1
+git -C "$PROJECT_DIR" config user.email "test@example.com"
+git -C "$PROJECT_DIR" config user.name "Test User"
+touch "$PROJECT_DIR/README.md"
+git -C "$PROJECT_DIR" add .
+git -C "$PROJECT_DIR" commit -m "Initial commit" >/dev/null 2>&1
+
+# Create project via IPC
+PROJECT_RESPONSE=$(curl -sf -X POST "http://${SERVER_HOST}:${SERVER_PORT}/ipc/project%3Acreate" \
+  -H "Content-Type: application/json" \
+  -d "{\"args\": [\"$PROJECT_DIR\"]}" || true)
+
+if [[ -z "$PROJECT_RESPONSE" ]]; then
+  log_error "Project creation returned empty response"
+  rm -rf "$PROJECT_DIR"
+  exit 1
+fi
+
+if ! echo "$PROJECT_RESPONSE" | jq -e '.success == true' >/dev/null 2>&1; then
+  log_error "Project creation failed: $PROJECT_RESPONSE"
+  rm -rf "$PROJECT_DIR"
+  exit 1
+fi
+
+log_info "✅ Project created via IPC"
+
+# Create workspace via IPC - this exercises more of the IPC layer
+log_info "Testing IPC workspace creation..."
+WORKSPACE_RESPONSE=$(curl -sf -X POST "http://${SERVER_HOST}:${SERVER_PORT}/ipc/workspace%3Acreate" \
+  -H "Content-Type: application/json" \
+  -d "{\"args\": [\"$PROJECT_DIR\", \"smoke-test-branch\", \"main\"]}" || true)
+
+if [[ -z "$WORKSPACE_RESPONSE" ]]; then
+  log_error "Workspace creation returned empty response"
+  rm -rf "$PROJECT_DIR"
+  exit 1
+fi
+
+if ! echo "$WORKSPACE_RESPONSE" | jq -e '.success == true' >/dev/null 2>&1; then
+  log_error "Workspace creation failed: $WORKSPACE_RESPONSE"
+  rm -rf "$PROJECT_DIR"
+  exit 1
+fi
+
+WORKSPACE_ID=$(echo "$WORKSPACE_RESPONSE" | jq -r '.data.metadata.id // .data.id // empty')
+if [[ -z "$WORKSPACE_ID" ]]; then
+  log_error "Workspace ID not returned from creation"
+  rm -rf "$PROJECT_DIR"
+  exit 1
+fi
+
+log_info "✅ Workspace created via IPC (id: $WORKSPACE_ID)"
+
+# Test WebSocket subscription - this triggers MockBrowserWindow.isDestroyed() checks
+# The chat subscription triggers getOrCreateSession() which registers event handlers
+# that call isDestroyed() before sending messages
+log_info "Testing WebSocket chat subscription..."
+
+# Use Node.js to test WebSocket since it's guaranteed to be available
+node -e "
+const WebSocket = require('ws');
+const ws = new WebSocket('ws://${SERVER_HOST}:${SERVER_PORT}/ws');
+
+const timeout = setTimeout(() => {
+  console.log('WebSocket test timed out (expected - no messages to replay)');
+  ws.close();
+  process.exit(0);
+}, 3000);
+
+ws.on('open', () => {
+  // Subscribe to workspace chat - this triggers session creation and isDestroyed() checks
+  ws.send(JSON.stringify({
+    type: 'subscribe',
+    channel: 'workspace:chat',
+    workspaceId: '${WORKSPACE_ID}'
+  }));
+  
+  // Also subscribe to metadata to exercise that code path
+  ws.send(JSON.stringify({
+    type: 'subscribe',
+    channel: 'workspace:metadata'
+  }));
+});
+
+ws.on('message', (data) => {
+  console.log('Received WebSocket message');
+  clearTimeout(timeout);
+  ws.close();
+  process.exit(0);
+});
+
+ws.on('error', (err) => {
+  console.error('WebSocket error:', err.message);
+  clearTimeout(timeout);
+  process.exit(1);
+});
+" 2>&1
+
+WS_EXIT_CODE=$?
+if [[ $WS_EXIT_CODE -ne 0 ]]; then
+  log_error "WebSocket subscription test failed"
+  rm -rf "$PROJECT_DIR"
+  exit 1
+fi
+
+log_info "✅ WebSocket subscription completed without errors"
+
+# Cleanup test project
+rm -rf "$PROJECT_DIR"
+
 # All tests passed
 log_info "🎉 All smoke tests passed!"