cleanup: simplify selective test system

- Remove run-selective-tests.sh (logic is inline in CI workflow)
- Move CI/.github from infrastructure to ignored (doesn't affect tests)
- Add more ignored patterns (e2e tests, electron-builder)
- Fix verbose output capture in CI workflow
- Minor comment improvements

Author: ammar-agent

.github/workflows/ci.yml

@@ -123,21 +123,22 @@ jobs:
         if: github.event.inputs.test_filter == '' && steps.coverage-map-cache.outputs.cache-hit != ''
         id: select-tests
         run: |
-          # Run selection script and capture output
           set +e
           SELECTED=$(bun scripts/selective-tests/select-affected-tests.ts \
             --map coverage-map.json \
             --base origin/${{ github.base_ref || 'main' }} \
             --head ${{ github.sha }} \
             --output jest \
-            --verbose)
+            --verbose 2>&1)
           EXIT_CODE=$?
           set -e
 
-          echo "exit_code=$EXIT_CODE" >> $GITHUB_OUTPUT
+          # Extract just the test list (last line of output)
+          TEST_LIST=$(echo "$SELECTED" | tail -1)
 
+          echo "exit_code=$EXIT_CODE" >> $GITHUB_OUTPUT
           if [[ $EXIT_CODE -eq 0 ]]; then
-            echo "selected_tests=$SELECTED" >> $GITHUB_OUTPUT
+            echo "selected_tests=$TEST_LIST" >> $GITHUB_OUTPUT
             echo "run_selective=true" >> $GITHUB_OUTPUT
           else
             echo "run_selective=false" >> $GITHUB_OUTPUT

scripts/selective-tests/README.md

@@ -21,10 +21,9 @@ This system reduces CI time by running only the integration tests affected by co
 
 ## Files
 
-- `types.ts` - Shared types and constants
+- `types.ts` - Shared types and infrastructure file patterns
 - `generate-coverage-map.ts` - Generates the coverage map by running tests with coverage
 - `select-affected-tests.ts` - Selects tests based on changed files
-- `run-selective-tests.sh` - CI wrapper script with fallback handling
 
 ## Usage
 
@@ -86,14 +85,6 @@ These files trigger a full test run when changed (see `INFRASTRUCTURE_PATTERNS`
 - Service container: `src/node/services/serviceContainer.ts`
 - Shared types: `src/types/**`, `src/constants/**`
 
-## Shadow Mode
-
-For validation, run with `--shadow-mode` to log what would have been selected while still running all tests:
-
-```bash
-./scripts/selective-tests/run-selective-tests.sh --shadow-mode
-```
-
 ## Debugging
 
 Use `--verbose` for detailed logging:

scripts/selective-tests/generate-coverage-map.ts

@@ -20,6 +20,7 @@ import { createHash } from "crypto";
 import type { CoverageMap } from "./types";
 import { INFRASTRUCTURE_PATTERNS } from "./types";
 
+// Directories and defaults
 const TESTS_DIR = "tests/integration";
 const COVERAGE_DIR = "coverage";
 const DEFAULT_OUTPUT = "coverage-map.json";

scripts/selective-tests/run-selective-tests.sh

@@ -39,10 +39,11 @@ const minimatch = require("minimatch") as (
   options?: { matchBase?: boolean }
 ) => boolean;
 
+// Defaults
 const DEFAULT_MAP_PATH = "coverage-map.json";
 const DEFAULT_BASE_REF = "origin/main";
 const DEFAULT_HEAD_REF = "HEAD";
-const DEFAULT_MAX_STALENESS_DAYS = 7;
+const DEFAULT_MAX_STALENESS_DAYS = 7; // Fallback if map older than this
 
 interface Options {
   mapPath: string;
@@ -312,18 +313,27 @@ function selectAffectedTests(
       coverageMap.allTests.includes(f)
   );
 
-  // Non-source changes that we can ignore (docs, configs we don't care about, etc.)
+  // Non-source changes that we can safely ignore
   const ignoredPatterns = [
+    // Documentation
     "docs/**",
     "*.md",
     "*.mdx",
+    // Editor/repo config
     ".gitignore",
     ".editorconfig",
-    "LICENSE",
     ".vscode/**",
+    "LICENSE",
+    // Storybook (has its own tests)
     "storybook/**",
     ".storybook/**",
     "*.stories.tsx",
+    // CI workflows (changes here don't affect test results)
+    ".github/**",
+    // E2E tests (separate from integration tests)
+    "tests/e2e/**",
+    // Build artifacts
+    "electron-builder.yml",
   ];
 
   const ignoredChanges = changedFiles.filter((f) =>

scripts/selective-tests/select-affected-tests.ts

@@ -35,11 +35,11 @@ export interface AffectedTestsResult {
   unmappedFiles: string[];
 }
 
-/** Exit codes for scripts */
+/** Exit codes for scripts (2 = fallback so CI can distinguish from errors) */
 export const EXIT_CODES = {
   SUCCESS: 0,
-  FALLBACK_TRIGGERED: 2,
   ERROR: 1,
+  FALLBACK_TRIGGERED: 2,
 } as const;
 
 /** Infrastructure files that should trigger all tests when changed */
@@ -66,11 +66,6 @@ export const INFRASTRUCTURE_PATTERNS = [
 
   // Build configuration
   "vite.*.ts",
-  "electron-builder.yml",
-
-  // CI configuration
-  ".github/workflows/**",
-  ".github/actions/**",
 
   // This selective test system itself
   "scripts/selective-tests/**",