Skip to content

Commit 659fb79

Browse files
author
Test
committed
🤖 fix: restore scrolling in run settings model list
- Wrap model list in nested ScrollView with max height and indicators - Keep non-virtualized implementation to avoid ScrollView + VirtualizedList warning Generated with Change-Id: I4411270d61b9697e4cdac35300ff8c938c5dcdaa Signed-off-by: Test <test@example.com>
1 parent 0ee3e39 commit 659fb79

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

apps/mobile/src/components/RunSettingsSheet.tsx

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ interface SectionProps {
5151
function SectionCard(props: SectionProps): JSX.Element {
5252
const theme = useTheme();
5353
return (
54-
<View style={[styles.sectionCard, { borderColor: theme.colors.border }]}>
54+
<View style={[styles.sectionCard, { borderColor: theme.colors.border }]}>
5555
<Pressable
5656
onPress={props.onToggle}
5757
style={({ pressed }) => [
@@ -127,7 +127,7 @@ export function RunSettingsSheet(props: RunSettingsSheetProps): JSX.Element {
127127
presentationStyle="pageSheet"
128128
onRequestClose={props.onClose}
129129
>
130-
<View style={[styles.container, { backgroundColor: theme.colors.background }]}>
130+
<View style={[styles.container, { backgroundColor: theme.colors.background }]}>
131131
<View style={styles.header}>
132132
<ThemedText variant="titleMedium" weight="semibold">
133133
Run settings
@@ -209,7 +209,12 @@ export function RunSettingsSheet(props: RunSettingsSheetProps): JSX.Element {
209209
</View>
210210
)}
211211

212-
<View style={styles.modelList}>
212+
<ScrollView
213+
style={styles.modelList}
214+
nestedScrollEnabled
215+
keyboardShouldPersistTaps="handled"
216+
showsVerticalScrollIndicator
217+
>
213218
{filteredModels.length === 0 ? (
214219
<View style={{ padding: 24 }}>
215220
<ThemedText variant="caption" style={{ textAlign: "center" }}>
@@ -248,7 +253,7 @@ export function RunSettingsSheet(props: RunSettingsSheetProps): JSX.Element {
248253
</View>
249254
))
250255
)}
251-
</View>
256+
</ScrollView>
252257
</SectionCard>
253258

254259
<SectionCard
@@ -279,7 +284,7 @@ export function RunSettingsSheet(props: RunSettingsSheetProps): JSX.Element {
279284
{modeOption}
280285
</ThemedText>
281286
<ThemedText variant="caption" style={{ color: theme.colors.foregroundMuted }}>
282-
{modeOption === "plan" ? "Ask before executing" : "Act directly"}
287+
{modeOption === "plan" ? "Plan before executing" : "Act directly"}
283288
</ThemedText>
284289
</Pressable>
285290
))}

0 commit comments

Comments
 (0)