fix: ESLint and formatting issues in browser API tests

Author: kylecarbs

src/browser/api.test.ts

@@ -6,25 +6,27 @@
 import { describe, test, expect } from "bun:test";
 
 // Helper to create a mock fetch that returns a specific response
-function createMockFetch(responseData: any) {
-  return async () => {
-    return {
+function createMockFetch(responseData: unknown) {
+  return () => {
+    return Promise.resolve({
       ok: true,
-      json: async () => responseData,
-    } as Response;
+      json: () => Promise.resolve(responseData),
+    } as Response);
   };
 }
 
+interface InvokeResponse<T> {
+  success: boolean;
+  data?: T;
+  error?: unknown;
+}
+
 // Helper to create invokeIPC function with mocked fetch
-async function createInvokeIPC(mockFetch: any) {
+function createInvokeIPC(
+  mockFetch: (url: string, init?: RequestInit) => Promise<Response>
+): <T>(channel: string, ...args: unknown[]) => Promise<T> {
   const API_BASE = "http://localhost:3000";
 
-  interface InvokeResponse<T> {
-    success: boolean;
-    data?: T;
-    error?: unknown;
-  }
-
   async function invokeIPC<T>(channel: string, ...args: unknown[]): Promise<T> {
     const response = await mockFetch(`${API_BASE}/ipc/${encodeURIComponent(channel)}`, {
       method: "POST",
@@ -64,9 +66,10 @@ describe("Browser API invokeIPC", () => {
       error: "fatal: contains modified or untracked files",
     });
 
-    const invokeIPC = await createInvokeIPC(mockFetch);
+    const invokeIPC = createInvokeIPC(mockFetch);
 
     // Current behavior: invokeIPC throws on string errors
+    // eslint-disable-next-line @typescript-eslint/await-thenable
     await expect(invokeIPC("WORKSPACE_REMOVE", "test-workspace", { force: false })).rejects.toThrow(
       "fatal: contains modified or untracked files"
     );
@@ -78,7 +81,7 @@ describe("Browser API invokeIPC", () => {
       error: "fatal: contains modified or untracked files",
     });
 
-    const invokeIPC = await createInvokeIPC(mockFetch);
+    const invokeIPC = createInvokeIPC(mockFetch);
 
     // Desired behavior: Should return { success: false, error: "..." }
     // This test documents what we want - actual implementation test is below
@@ -100,23 +103,24 @@ describe("Browser API invokeIPC", () => {
       data: { someData: "value" },
     });
 
-    const invokeIPC = await createInvokeIPC(mockFetch);
+    const invokeIPC = createInvokeIPC(mockFetch);
 
     const result = await invokeIPC("WORKSPACE_REMOVE", "test-workspace", { force: true });
 
     expect(result).toEqual({ someData: "value" });
   });
 
   test("should throw on HTTP errors", async () => {
-    const mockFetch = async () => {
-      return {
+    const mockFetch = () => {
+      return Promise.resolve({
         ok: false,
         status: 500,
-      } as Response;
+      } as Response);
     };
 
-    const invokeIPC = await createInvokeIPC(mockFetch);
+    const invokeIPC = createInvokeIPC(mockFetch);
 
+    // eslint-disable-next-line @typescript-eslint/await-thenable
     await expect(invokeIPC("WORKSPACE_REMOVE", "test-workspace", { force: false })).rejects.toThrow(
       "HTTP error! status: 500"
     );
@@ -134,7 +138,7 @@ describe("Browser API invokeIPC", () => {
       error: structuredError,
     });
 
-    const invokeIPC = await createInvokeIPC(mockFetch);
+    const invokeIPC = createInvokeIPC(mockFetch);
 
     const result = await invokeIPC("WORKSPACE_SEND_MESSAGE", "test-workspace", {
       role: "user",
@@ -148,4 +152,3 @@ describe("Browser API invokeIPC", () => {
     });
   });
 });
-