🤖 fix: avoid infinite rerender for live bash output

Change-Id: Idb868686d632862e0ed5c9b472670fd49ecd6e8a
Signed-off-by: Thomas Kosiewski <tk@coder.com>

Author: ThomasK33

src/browser/stores/WorkspaceStore.test.ts

@@ -671,8 +671,14 @@ describe("WorkspaceStore", () => {
 
       const live = store.getBashToolLiveOutput(workspaceId, "call-1");
       expect(live).not.toBeNull();
-      expect(live?.stdout).toContain("out");
-      expect(live?.stderr).toContain("err");
+      if (!live) throw new Error("Expected live output");
+
+      // getSnapshot in useSyncExternalStore requires referential stability when unchanged.
+      const liveAgain = store.getBashToolLiveOutput(workspaceId, "call-1");
+      expect(liveAgain).toBe(live);
+
+      expect(live.stdout).toContain("out");
+      expect(live.stderr).toContain("err");
     });
 
     it("clears live output when bash tool result includes output", async () => {

src/browser/stores/WorkspaceStore.ts

@@ -34,7 +34,6 @@ import type { LanguageModelV2Usage } from "@ai-sdk/provider";
 import { createFreshRetryState } from "@/browser/utils/messages/retryState";
 import {
   appendLiveBashOutputChunk,
-  toLiveBashOutputView,
   type LiveBashOutputInternal,
   type LiveBashOutputView,
 } from "@/browser/utils/messages/liveBashOutputBuffer";
@@ -704,7 +703,10 @@ export class WorkspaceStore {
   getBashToolLiveOutput(workspaceId: string, toolCallId: string): LiveBashOutputView | null {
     const perWorkspace = this.liveBashOutput.get(workspaceId);
     const state = perWorkspace?.get(toolCallId);
-    return state ? toLiveBashOutputView(state) : null;
+
+    // Important: return the stored object reference so useSyncExternalStore sees a stable snapshot.
+    // (Returning a fresh object every call can trigger an infinite re-render loop.)
+    return state ?? null;
   }
 
   /**