Skip to content

Commit 930d5f4

Browse files
committed
fix: convert tarball path to absolute and run on PRs
- Convert PACKAGE_TARBALL to absolute path before cd to avoid path resolution issues - Add pull_request trigger to smoke-test workflow so it runs on PRs Addresses Codex feedback about tarball path being relative after cd. _Generated with `mux`_
1 parent 5f9740b commit 930d5f4

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

.github/workflows/smoke-test.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: Smoke Test
22

33
on:
4+
pull_request:
5+
branches: ["**"]
46
push:
57
branches:
68
- main

scripts/smoke-test.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,9 @@ if [[ ! -f "$PACKAGE_TARBALL" ]]; then
7171
exit 1
7272
fi
7373

74+
# Convert to absolute path before changing directories
75+
PACKAGE_TARBALL=$(realpath "$PACKAGE_TARBALL")
76+
7477
log_info "Starting smoke test for package: $PACKAGE_TARBALL"
7578

7679
# Create temporary test directory

0 commit comments

Comments
 (0)